You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/01/06 08:50:20 UTC
Review Request 71956: Added a test `ROOT_CGROUPS_CFS_EnableCpuLimit`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_EnableCpuLimit`.
Diffs
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219182
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 71944, 71950, 71951, 71952, 71953, 71955, 71956]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 7, 2020, 3:06 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2020, 3:06 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219190
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 71944, 71950, 71951, 71952, 71953, 71955, 71956]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 7, 2020, 3:06 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2020, 3:06 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219153
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 71944, 71950, 71951, 71952, 71953, 71955, 71956]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 7, 2020, 3:06 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2020, 3:06 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
> On March 6, 2020, 1:44 a.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 527 (patched)
> > <https://reviews.apache.org/r/71956/diff/4/?file=2207386#file2207386line527>
> >
> > Isn't the agent here currently using all of the host memory?
My bad, thanks for catching it!
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219803
-----------------------------------------------------------
On March 10, 2020, 4:53 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated March 10, 2020, 4:53 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219803
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 527 (patched)
<https://reviews.apache.org/r/71956/#comment308033>
Isn't the agent here currently using all of the host memory?
- Greg Mann
On Jan. 15, 2020, 2:24 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2020, 2:24 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/4/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated March 16, 2020, 9:51 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Minor change.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/8/
Changes: https://reviews.apache.org/r/71956/diff/7-8/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated March 16, 2020, 5:13 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Rebased.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/7/
Changes: https://reviews.apache.org/r/71956/diff/6-7/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated March 13, 2020, 9:21 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Rebased.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/6/
Changes: https://reviews.apache.org/r/71956/diff/5-6/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated March 10, 2020, 4:53 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/5/
Changes: https://reviews.apache.org/r/71956/diff/4-5/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated Jan. 15, 2020, 10:24 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Minor changes.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/4/
Changes: https://reviews.apache.org/r/71956/diff/3-4/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated Jan. 13, 2020, 4:06 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Checked the CPU and memory soft limits.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/3/
Changes: https://reviews.apache.org/r/71956/diff/2-3/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219169
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 71944, 71950, 71951, 71952, 71953, 71955, 71956]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 7, 2020, 7:06 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2020, 7:06 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_CommandTaskLimits`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/
-----------------------------------------------------------
(Updated Jan. 7, 2020, 11:06 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Checked memory hard limit and OOM score adjust as well.
Summary (updated)
-----------------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Bugs: MESOS-10047
https://issues.apache.org/jira/browse/MESOS-10047
Repository: mesos
Description (updated)
-------
Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Diffs (updated)
-----
src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
Diff: https://reviews.apache.org/r/71956/diff/2/
Changes: https://reviews.apache.org/r/71956/diff/1-2/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 71956: Added a test
`ROOT_CGROUPS_CFS_EnableCpuLimit`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219128
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71855, 71931, 71856, 71858, 71884, 71885, 71886, 71943, 71944, 71950, 71951, 71952, 71953, 71955, 71956]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 6, 2020, 8:50 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2020, 8:50 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10047
> https://issues.apache.org/jira/browse/MESOS-10047
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_CGROUPS_CFS_EnableCpuLimit`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e
>
>
> Diff: https://reviews.apache.org/r/71956/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>