You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/22 13:28:27 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4164: Adding listall to listLdapConfigurations

davidjumani opened a new pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164


   ## Description
   Adds the listall parameter to listLdapConfigurations.
   If set to true, and no domainid specified, list all LDAP configurations irrespective of the linked domain
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   ```
   (localhost) 🐱 > list ldapconfigurations listall=true 
   {
     "LdapConfiguration": [
       {
         "domainid": "3eca21e9-b1f3-11ea-ba9c-50eb71576f75",
         "hostname": "primate-qa.cloudstack.cloud",
         "port": 389
       },
       {
         "domainid": "2b660440-759f-4490-99ba-cddd9cbff2af",
         "hostname": "primate-qa.cloudstack.cloud",
         "port": 389
       },
       {
         "hostname": "primate-qa.cloudstack.cloud",
         "port": 389
       }
     ],
     "count": 3
   }
   (localhost) 🐱 > list ldapconfigurations 
   {
     "LdapConfiguration": [
       {
         "hostname": "primate-qa.cloudstack.cloud",
         "port": 389
       }
     ],
     "count": 1
   }
   (localhost) 🐱 > list ldapconfigurations domainid=2b660440-759f-4490-99ba-cddd9cbff2af listall=true 
   {
     "LdapConfiguration": [
       {
         "domainid": "2b660440-759f-4490-99ba-cddd9cbff2af",
         "hostname": "primate-qa.cloudstack.cloud",
         "port": 389
       }
     ],
     "count": 1
   }
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648800402


   <b>Trillian test result (tid-1828)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27968 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4164-t1828-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 176.53 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.72 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 237.66 | test_privategw_acl.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648091648


   @rhtyd casn you have a look as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#discussion_r444288743



##########
File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java
##########
@@ -117,4 +121,8 @@ public void setPort(final int port) {
     public void setDomainId(final Long domainId) {
         this.domainId = domainId;
     }
+
+    public boolean listAll() {
+        return listAll == null ? false : listAll;

Review comment:
       nit - can be simplified as listAll != null && listAll




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648571341


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579715


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#discussion_r444288743



##########
File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java
##########
@@ -117,4 +121,8 @@ public void setPort(final int port) {
     public void setDomainId(final Long domainId) {
         this.domainId = domainId;
     }
+
+    public boolean listAll() {
+        return listAll == null ? false : listAll;

Review comment:
       can be simplified as listAll != null && listAll




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579421


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647931068


   @DaanHoogland tested and working for multiple servers


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648576739


   Packaging result: ✔centos7 ✔debian. JID-1441


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579290


   @blueorangutan test 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647520882


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648570963


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647520392


   @rhtyd Added this to allow primate to work properly
   @DaanHoogland Looks good ?
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647546383


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648552507


   @davidjumani can you change the base branch to at least 4.14 and kick tests again? We want any bugfixes and API improvements (for Primate) to at least go into 4.14 branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647891250


   <b>Trillian test result (tid-1811)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47262 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4164-t1811-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_create_pvlan_network | `Error` | 0.03 | test_pvlan.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 327.85 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 3780.82 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647536018


   Packaging result: ✔centos7 ✔debian. JID-1427


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-647546807


   @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani removed a comment on pull request #4164: Adding listall to listLdapConfigurations

Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#issuecomment-648579715


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org