You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 18:02:54 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #1084: support cast decimal to decimal

alamb commented on a change in pull request #1084:
URL: https://github.com/apache/arrow-rs/pull/1084#discussion_r774073239



##########
File path: arrow/src/compute/kernels/cast.rs
##########
@@ -1908,6 +1945,14 @@ mod tests {
     use crate::{buffer::Buffer, util::display::array_value_to_string};
     use num::traits::Pow;
 
+    #[test]
+    fn test_cast_decimal_to_decimal() {
+        let input_type = DataType::Decimal(20, 3);
+        let output_type = DataType::Decimal(20, 4);
+        assert!(can_cast_types(&input_type, &output_type));
+        // let array = vec![Some(1123456), Some(2123456), Some(3123456), None];

Review comment:
       looks like we just need some tests here, and we'll be all set 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org