You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/17 03:09:47 UTC

[GitHub] [apisix-dashboard] idbeta commented on pull request #1056: feat: Refactor frontend e2e

idbeta commented on pull request #1056:
URL: https://github.com/apache/apisix-dashboard/pull/1056#issuecomment-747175312


   > LGTM except for 2 things:
   > 
   > 1. The CreateRouteTest needs @idbeta's confirmation;
   > 2. hmm we have some Chinese in this test, this issue is related to i18n, could resolve it in other PR :)
   
   CreateRouteTest is ok, I think it should enable some plugins in the route.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org