You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joe Stein <cr...@gmail.com> on 2013/11/21 00:54:48 UTC

Review Request 15743: Patch for KAFKA-1133

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15743/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1133
    https://issues.apache.org/jira/browse/KAFKA-1133


Repository: kafka


Description
-------

KAFKA-1133 LICENSE and NOTICE files need to get into META-INF when jars are built before they're signed for publishing to maven


KAFKA-1131 copy license and notice to the release files, reviewed by David Arthur


KAFKA-1126 Remove the DISCLAIMER it is left over from incubation reviewed by Neha


KAFKA-1094 Configure reviewboard url in kafka-patch-review tool; reviewed by Neha Narkhede


KAFKA-1086 Improve GetOffsetShell to find metadata automatically; reviwed by Jun Rao and Joel Koshy


KAFKA-1089; Fix run-class and log4j for migration tool system test; reviewed by Jun Rao


KAFKA-1087 Empty topic list causes consumer to fetch metadata of all topics; reviewed by Guozhang Wang and Neha Narkhede


KAFKA-1081 Remove re-run functionality from start script and use exec to launch commands to avoid spurious .sh process.


KAFKA-1018 tidy up the pom, 0.8.0 release, build the test jars now too


KAFKA-1008 Unmap offset indexes before resizing.


Diffs
-----

  DISCLAIMER 950e15d67781b07a837fd8a4c6a4b91c4c02d6f5 
  bin/kafka-add-partitions.sh c08b837cd0dcb601e2f089336ef07f283e4cf613 
  bin/kafka-console-consumer.sh 95edc9e5bff1207d92bd55e2f887f83b507bcb6f 
  bin/kafka-console-producer.sh f102c2239a55c898f2a4e0b5154c4d8f5e3037de 
  bin/kafka-consumer-perf-test.sh 39434d162e54063b12ee9fa027326f2ad74d31b1 
  bin/kafka-create-topic.sh 7a5f29735fceb9e4f87fb8e0b1f910e48bb705c1 
  bin/kafka-list-topic.sh bb2dde52c0d5775e025854c62e428d0b8cf4492e 
  bin/kafka-preferred-replica-election.sh 6416dc1614002c17fdec94fc21fd88c9163bae0b 
  bin/kafka-producer-perf-test.sh 1935522079cddf7e245ce043ae33e5ad8fda2ad5 
  bin/kafka-reassign-partitions.sh a6bd148752bb8ab1e46c60f3745bdf3d83b4bcc9 
  bin/kafka-replay-log-producer.sh 86943eed22e3a3ca9a825367ecda64d0c8d84dd1 
  bin/kafka-run-class.sh eb6ff1b12e53813622d0dd44588f74c9516d0919 
  bin/kafka-server-start.sh 4005289428d5d602d12562f834ea78dc79e2fc2b 
  bin/kafka-simple-consumer-perf-test.sh 94c9ed0bfc28353695d0dcd1eec4530c89bf25da 
  bin/kafka-simple-consumer-shell.sh 8d69357838f1bcb4476f70d599eda510cc8abbc7 
  bin/zookeeper-server-start.sh e4746a84b3b95f3a748762e932b83ceff8fd105f 
  bin/zookeeper-shell.sh e0de33f2e16e5d0057cd710ac5fbd51553d36e4c 
  core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala 8c033089691d30d4176f12fd037a680a4e2fb76d 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 36b167b28ac08286da05017aaf265cdecfbec591 
  core/src/main/scala/kafka/log/OffsetIndex.scala 9de3d31d7c8e964c835dd71e23bb84e6712a4f5e 
  core/src/main/scala/kafka/server/AbstractFetcherThread.scala a5fc96df72a0dc4d763985eb23b318a932e92a23 
  core/src/main/scala/kafka/tools/GetOffsetShell.scala 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d 
  core/src/main/scala/kafka/utils/Os.scala PRE-CREATION 
  core/src/main/scala/kafka/utils/Utils.scala e0a5a27c72abf3560f68fc6c2dbfc67d90cc5cd9 
  core/src/main/scala/kafka/utils/ZkUtils.scala 6eede1bde352a39a622899dc507cc8edfacbdafd 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala ee591d092b95c69917c5a65e2a42e873976edd5c 
  core/src/test/scala/unit/kafka/utils/UtilsTest.scala 6b21554feee092771168d392cb34dd7ee14e708b 
  kafka-patch-review.py f1d5192057755e9cd24861c1f995638e2eada1d1 
  project/Build.scala 33bb76f4ebb899610e66acd8af1d15c15af1f7cc 
  system_test/migration_tool_testsuite/0.7/bin/kafka-run-class.sh 8ebe7a7f3eb4a246cb3232a1631eb0e7fa66e976 
  system_test/migration_tool_testsuite/0.7/config/test-log4j.properties PRE-CREATION 
  system_test/utils/kafka_system_test_utils.py aec31cbf38ca36bff2b6d9d5439b62905e901610 

Diff: https://reviews.apache.org/r/15743/diff/


Testing
-------


Thanks,

Joe Stein