You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/08/21 20:54:41 UTC
Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and James Peach.
Repository: mesos
Description
-------
Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Diffs
-----
src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
Diff: https://reviews.apache.org/r/61801/diff/1/
Testing
-------
sudo make check (mac os x, fedora 25)
internal CI
Thanks,
Andrei Budnik
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review184113
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61797, 61798, 61799, 61800, 61801]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 21, 2017, 1:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 1:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/3/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review183394
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61797, 61798, 61799, 61800, 61801]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 21, 2017, 4:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 4:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/1/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/cgroups_tests.cpp
> > Line 489 (original), 490 (patched)
> > <https://reviews.apache.org/r/61801/diff/1/?file=1801036#file1801036line490>
> >
> > Why did you drop this comment?
Because the following message asserts the same?
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review183464
-----------------------------------------------------------
On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 8:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/1/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review183464
-----------------------------------------------------------
src/tests/containerizer/cgroups_tests.cpp
Line 489 (original), 490 (patched)
<https://reviews.apache.org/r/61801/#comment259478>
Why did you drop this comment?
- Alexander Rukletsov
On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 8:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/1/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review183918
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61797, 61798, 61799, 61800, 61801]
Logs available here: http://104.210.40.105/logs/master/61801
- Mesos Reviewbot Windows
On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 8:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/2/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used SAFE_EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review184784
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 8:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used SAFE_EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/5/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review184108
-----------------------------------------------------------
Bad patch!
Reviews applied: [61797, 61798, 61799, 61800, 61801]
Logs available here: http://104.210.40.105/logs/master/61801
- Mesos Reviewbot Windows
On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 8:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/3/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 61801: Used _EXIT macro in
`CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61801/#review183882
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61797, 61798, 61799, 61800, 61801]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 21, 2017, 1:54 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61801/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 1:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin Mahler, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp c5d83e667da0b2c8c03937c66e2a973d547cd3d2
>
>
> Diff: https://reviews.apache.org/r/61801/diff/2/
>
>
> Testing
> -------
>
> sudo make check (mac os x, fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>