[GitHub] [maven-surefire] elharo commented on a diff in pull request #574: [SUREFIRE-1887] Trim stacktraces to include relevant lines

[GitBox <gi...@apache.org>]

elharo commented on code in PR #574:
URL: https://github.com/apache/maven-surefire/pull/574#discussion_r1044420785


##########
surefire-api/src/test/java/org/apache/maven/surefire/api/report/LegacyPojoStackTraceWriterTest.java:
##########
@@ -64,14 +65,18 @@ public void testWriteTrimmedTraceToString()
         MockThrowable t = new MockThrowable( stackTrace );
         LegacyPojoStackTraceWriter w = new LegacyPojoStackTraceWriter( "TestSurefire3", "testQuote", t );
         String out = w.writeTrimmedTraceToString();
-        String expected = "junit.framework.AssertionFailedError: blah\n" + "    at junit.framework.Assert.fail(Assert.java:47)\n" + "    at TestSurefire3.testQuote(TestSurefire3.java:23)\n";
+        String expected = "junit.framework.AssertionFailedError: blah\n"

Review Comment:
   I'm confused. This seems to add an extra line to the output and not remove anything. Is there a test that shows these changes making stack traces simpler?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org