You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "loserwang1024 (via GitHub)" <gi...@apache.org> on 2026/01/16 11:55:43 UTC
[PR] [server] Support projection pushdown with field id in server. [fluss]
loserwang1024 opened a new pull request, #2396:
URL: https://github.com/apache/fluss/pull/2396
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2311
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [server] Support projection pushdown with field id in server. [fluss]
Posted by "loserwang1024 (via GitHub)" <gi...@apache.org>.
loserwang1024 commented on PR #2396:
URL: https://github.com/apache/fluss/pull/2396#issuecomment-3767511557
@wuchong @libenchao @leonardBang , CC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [server] Support projection pushdown with field id in server. [fluss]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2396:
URL: https://github.com/apache/fluss/pull/2396#discussion_r2703849120
##########
fluss-server/src/main/java/org/apache/fluss/server/replica/ReplicaManager.java:
##########
@@ -153,7 +153,6 @@ public class ReplicaManager {
private final Map<TableBucket, HostedReplica> allReplicas = MapUtils.newConcurrentHashMap();
private final TabletServerMetadataCache metadataCache;
- private final ExecutorService ioExecutor;
private final ProjectionPushdownCache projectionsCache = new ProjectionPushdownCache();
Review Comment:
The field declaration for `ioExecutor` has been removed, but it is still being used at line 286 in the constructor (`this.kvSnapshotResource = KvSnapshotResource.create(serverId, conf, ioExecutor);`). This will cause a compilation error. The field should not have been removed.
##########
fluss-server/src/main/java/org/apache/fluss/server/utils/ServerRpcMessageUtils.java:
##########
@@ -822,6 +822,13 @@ public static Map<TableBucket, FetchReqInfo> getFetchLogData(FetchLogRequest req
projectionFields = null;
}
+ final boolean isSelectedByIds;
+ if (fetchLogReqForTable.isProjectByIds()) {
+ isSelectedByIds = fetchLogReqForTable.isProjectByIds();
+ } else {
+ isSelectedByIds = false;
+ }
Review Comment:
The conditional logic here is redundant. The condition `if (fetchLogReqForTable.isProjectByIds())` always evaluates the same as the assignment `isSelectedByIds = fetchLogReqForTable.isProjectByIds()`. This can be simplified to just `boolean isSelectedByIds = fetchLogReqForTable.isProjectByIds();` without the conditional check, since the default value for a missing optional boolean field in protobuf is false.
```suggestion
final boolean isSelectedByIds = fetchLogReqForTable.isProjectByIds();
```
##########
fluss-rpc/src/main/proto/FlussApi.proto:
##########
@@ -702,6 +702,7 @@ message PbFetchLogReqForTable {
required bool projection_pushdown_enabled = 2;
repeated int32 projected_fields = 3 [packed = true];
repeated PbFetchLogReqForBucket buckets_req = 4;
Review Comment:
The new `project_by_ids` field lacks a documentation comment. Consider adding a comment explaining what this field means, for example: "// if true, projected_fields are interpreted as field IDs; if false, they are field positions".
```suggestion
repeated PbFetchLogReqForBucket buckets_req = 4;
// If true, projected_fields are interpreted as field IDs; if false, they are field positions.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [server] Support projection pushdown with field id in server side. [fluss]
Posted by "github-actions[bot] (via GitHub) via issues" <is...@fluss.apache.org>.
github-actions[bot] commented on PR #2396:
URL: https://github.com/apache/fluss/pull/2396#issuecomment-7076633391
This PR has been marked as stale because it has had no activity for 60 days. It will be closed in 10 days unless it receives a new comment, commit or other update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org