You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/22 18:48:26 UTC
[GitHub] [helix] alirezazamani opened a new pull request #1390: Include pending messages getCurrentInstanceToTaskAssignments
alirezazamani opened a new pull request #1390:
URL: https://github.com/apache/helix/pull/1390
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1388
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR includes pending messages in getCurrentInstanceToTaskAssignments to calculate previously assigned tasks. It would help to avoid duplicate messages being sent to the participant. Also, it would avoid message mismatch messages being sent to the Task Framework pipeline. This PR is necessary to have because pending messages and currentState are located in two different folders.
### Tests
- [] The following is the result of the "mvn test" command on the appropriate module:
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1390: Include pending messages in getCurrentInstanceToTaskAssignments method
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1390:
URL: https://github.com/apache/helix/pull/1390#issuecomment-698646148
This PR is ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1390: Include pending messages in getCurrentInstanceToTaskAssignments method
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1390:
URL: https://github.com/apache/helix/pull/1390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1390: Include pending messages in getCurrentInstanceToTaskAssignments method
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1390:
URL: https://github.com/apache/helix/pull/1390#issuecomment-698625813
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1390: Include pending messages in getCurrentInstanceToTaskAssignments method
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1390:
URL: https://github.com/apache/helix/pull/1390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #1390: Include pending messages in getCurrentInstanceToTaskAssignments method
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #1390:
URL: https://github.com/apache/helix/pull/1390#issuecomment-698625813
> LGTM! 2 minor questions.
>
> 1. I remember there are 1200 or more tests. But it is 1199 in your result. Did we remove one?
> 2. Please follow the PR template and note the new test case that you added to the description of PR.
1- Rebased and ran the tests again and updated the test results.
2- Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org