You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by gy...@apache.org on 2019/09/10 07:52:52 UTC

[flink] branch master updated: [FLINK-13957] Log dynamic properties on job submission

This is an automated email from the ASF dual-hosted git repository.

gyfora pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ce6938  [FLINK-13957] Log dynamic properties on job submission
2ce6938 is described below

commit 2ce6938a7703aeb21779d825715d4c1e0e2c856c
Author: Matyas Orhidi <mo...@cloudera.com>
AuthorDate: Wed Sep 4 14:22:18 2019 +0200

    [FLINK-13957] Log dynamic properties on job submission
    
    Closes #9616
---
 .../src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java | 4 ++++
 .../src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java b/flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
index 8738b7f..2408e42 100644
--- a/flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
+++ b/flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
@@ -335,6 +335,10 @@ public class FlinkYarnSessionCli extends AbstractCustomCommandLine<ApplicationId
 
 		final Properties properties = cmd.getOptionProperties(dynamicproperties.getOpt());
 
+		for (String key : properties.stringPropertyNames()) {
+			LOG.info("Dynamic Property set: {}={}", key, GlobalConfiguration.isSensitive(key) ? GlobalConfiguration.HIDDEN_CONTENT : properties.getProperty(key));
+		}
+
 		String[] dynamicProperties = properties.stringPropertyNames().stream()
 			.flatMap(
 				(String key) -> {
diff --git a/flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java b/flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java
index 3ee3654..287aefe 100644
--- a/flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java
+++ b/flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java
@@ -83,7 +83,7 @@ public class FlinkYarnSessionCliTest extends TestLogger {
 
 		CommandLineParser parser = new DefaultParser();
 		CommandLine cmd = parser.parse(options, new String[]{"run", "-j", "fake.jar", "-n", "15",
-				"-D", "akka.ask.timeout=5 min", "-D", "env.java.opts=-DappName=foobar"});
+				"-D", "akka.ask.timeout=5 min", "-D", "env.java.opts=-DappName=foobar", "-D", "security.ssl.internal.key-password=changeit"});
 
 		AbstractYarnClusterDescriptor flinkYarnDescriptor = cli.createClusterDescriptor(cmd);
 
@@ -91,9 +91,10 @@ public class FlinkYarnSessionCliTest extends TestLogger {
 
 		Map<String, String> dynProperties =
 			FlinkYarnSessionCli.getDynamicProperties(flinkYarnDescriptor.getDynamicPropertiesEncoded());
-		assertEquals(2, dynProperties.size());
+		assertEquals(3, dynProperties.size());
 		assertEquals("5 min", dynProperties.get("akka.ask.timeout"));
 		assertEquals("-DappName=foobar", dynProperties.get("env.java.opts"));
+		assertEquals("changeit", dynProperties.get("security.ssl.internal.key-password"));
 	}
 
 	@Test