You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "John Sichi (JIRA)" <ji...@apache.org> on 2011/06/09 19:53:59 UTC

[jira] [Created] (HIVE-2210) ALTER VIEW RENAME

ALTER VIEW RENAME
-----------------

                 Key: HIVE-2210
                 URL: https://issues.apache.org/jira/browse/HIVE-2210
             Project: Hive
          Issue Type: Improvement
          Components: Query Processor
    Affects Versions: 0.6.0
            Reporter: John Sichi
            Assignee: John Sichi


ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062103#comment-13062103 ] 

John Sichi commented on HIVE-2210:
----------------------------------

+1.  Will commit when tests pass.


> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch, HIVE-2210v1.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen updated HIVE-2210:
-------------------------------

    Attachment: altertablediff3.txt

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>         Attachments: altertablediff3.txt
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061635#comment-13061635 ] 

jiraposter@reviews.apache.org commented on HIVE-2210:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
-----------------------------------------------------------

Review request for hive.


Summary
-------

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
    https://issues.apache.org/jira/browse/HIVE-2210


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
-------

Relevant unit tests looked ok


Thanks,

Charles



> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061634#comment-13061634 ] 

jiraposter@reviews.apache.org commented on HIVE-2210:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
-----------------------------------------------------------

(Updated 2011-07-07 22:35:58.987287)


Review request for hive.


Summary (updated)
-------

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
    https://issues.apache.org/jira/browse/HIVE-2210


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1143958 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
-------

Relevant unit tests looked ok


Thanks,

Charles



> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061702#comment-13061702 ] 

jiraposter@reviews.apache.org commented on HIVE-2210:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/#review997
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
<https://reviews.apache.org/r/1039/#comment2062>

    update comment



http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
<https://reviews.apache.org/r/1039/#comment2059>

    Use TableType.VIRTUAL_VIEW.toString() instead of literal.



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/1039/#comment2064>

    comment says DROP



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
<https://reviews.apache.org/r/1039/#comment2084>

    For completeness, can you add a SELECT statement to make sure it's still possible to query the renamed view?  It's OK if it returns no results, just that semantic analysis passes.
    


- John


On 2011-07-07 22:35:58, Charles Chen wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1039/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-07 22:35:58)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/HIVE-2210
bq.  
bq.  
bq.  This addresses bug HIVE-2210.
bq.      https://issues.apache.org/jira/browse/HIVE-2210
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1143958 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1143958 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1143958 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1143958 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1143958 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1143958 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1039/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Relevant unit tests looked ok
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.



> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2210:
-----------------------------

    Status: Open  (was: Patch Available)

Resubmit patch after review comments addressed.

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen reassigned HIVE-2210:
----------------------------------

    Assignee: Charles Chen  (was: John Sichi)

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen updated HIVE-2210:
-------------------------------

    Attachment:     (was: altertablediff3.txt)

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen updated HIVE-2210:
-------------------------------

    Attachment: HIVE-2210v1.patch

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch, HIVE-2210v1.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen updated HIVE-2210:
-------------------------------

    Attachment: HIVE-2210v0.patch

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-2210:
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed.  Thanks Charles!  Don't forget to update the wiki.

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2210v0.patch, HIVE-2210v1.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen updated HIVE-2210:
-------------------------------

    Status: Patch Available  (was: Open)

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063324#comment-13063324 ] 

Hudson commented on HIVE-2210:
------------------------------

Integrated in Hive-trunk-h0.21 #820 (See [https://builds.apache.org/job/Hive-trunk-h0.21/820/])
    HIVE-2210. ALTER VIEW RENAME (Charles Chen via jvs)

jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1145048
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
* /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out
* /hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
* /hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out
* /hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
* /hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q
* /hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java


> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch, HIVE-2210v1.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2210) ALTER VIEW RENAME

Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Chen updated HIVE-2210:
-------------------------------

    Status: Patch Available  (was: Open)

Adds ALTER TABLE RENAME

> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>         Attachments: altertablediff3.txt
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2210) ALTER VIEW RENAME

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062013#comment-13062013 ] 

jiraposter@reviews.apache.org commented on HIVE-2210:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1039/
-----------------------------------------------------------

(Updated 2011-07-08 15:27:41.458614)


Review request for hive.


Changes
-------

Fixed changes in comments


Summary
-------

https://issues.apache.org/jira/browse/HIVE-2210


This addresses bug HIVE-2210.
    https://issues.apache.org/jira/browse/HIVE-2210


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1144352 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1144352 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1144352 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1144352 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1144352 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1144352 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure8.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/alter_view_failure9.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/alter_view_rename.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure8.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/alter_view_failure9.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/alter_view_rename.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1039/diff


Testing
-------

Relevant unit tests looked ok


Thanks,

Charles



> ALTER VIEW RENAME
> -----------------
>
>                 Key: HIVE-2210
>                 URL: https://issues.apache.org/jira/browse/HIVE-2210
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-2210v0.patch
>
>
> ALTER TABLE RENAME cannot be used on a view; we should support ALTER VIEW RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira