[GitHub] [hive] vcsomor commented on pull request #2974: HIVE-25746 Fix of Compaction Failure Counter counted incorrectly

[GitBox <gi...@apache.org>]

vcsomor commented on pull request #2974:
URL: https://github.com/apache/hive/pull/2974#issuecomment-1026592281


   > The only thing that gave me pause was that we call getOrCreateCounter every time the metric is incremented, since this means that all the counters must be iterated through... it should be fast but on the other hand I don't think there's a limit to the number of counters that can be created... what do you think?
   
   @klcopp I deliberately put there the `getOrCreateCounter` because in the majority of the cycles we don't need it (I mean the success case has more probability). It must be iterated through only if there is an issue. Furthermore the Initiatitor/Cleaners might run long and such `getOrCreateCounter` calls are negligible compared to the whole cycle time.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org