You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2024/04/24 12:04:50 UTC
[PR] doc(trait): Maven profile cm/secret additional information [camel-k]
gansheer opened a new pull request, #5416:
URL: https://github.com/apache/camel-k/pull/5416
Ref #5372
Add warning on resource namespace for maven profile.
**Release Note**
```release-note
doc(trait): Maven profile cm/secret additional information
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] doc(trait): Maven profile cm/secret additional information [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5416:
URL: https://github.com/apache/camel-k/pull/5416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] doc(trait): Maven profile cm/secret additional information [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5416:
URL: https://github.com/apache/camel-k/pull/5416#issuecomment-2076610913
Please, backport to 2.3 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] doc(trait): Maven profile cm/secret additional information [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5416:
URL: https://github.com/apache/camel-k/pull/5416#discussion_r1577823745
##########
pkg/apis/camel/v1/trait/builder.go:
##########
@@ -51,6 +51,7 @@ type BuilderTrait struct {
// Deprecated: use TasksRequestCPU instead with task name `builder`.
LimitMemory string `property:"limit-memory" json:"limitMemory,omitempty"`
// A list of references pointing to configmaps/secrets that contains a maven profile.
+ // This configmap/secret is a resource of the IntegrationKit created, therefor it needs to be present in the namespace where the operator is going to create the IntegrationKit.
Review Comment:
```suggestion
// This configmap/secret is a resource of the IntegrationKit created, therefore it needs to be present in the namespace where the operator is going to create the IntegrationKit.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org