[jira] Updated: (THRIFT-877) smalltalk namespace doesn't work

["Bruce Lowekamp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Lowekamp updated THRIFT-877:
----------------------------------

    Attachment: ns_smalltalk.patch

> smalltalk namespace doesn't work
> --------------------------------
>
>                 Key: THRIFT-877
>                 URL: https://issues.apache.org/jira/browse/THRIFT-877
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>    Affects Versions: 0.5
>            Reporter: Bruce Lowekamp
>             Fix For: 0.5
>
>         Attachments: ns_smalltalk.patch
>
>
> The patch from THRIFT-857, applied as r987565, didn't work for smalltalk.  (sorry, I tested it with python, and didn't look too hard at the smalltalk)
> However, there's a bigger problem that the smalltalk generator is calling back into program_ to lookup namespaces using "smalltalk.<foo>" while it's registered as a generator for "st" so the root namespace check only allows "st.foo" namespaces.  I really hate this, but if there are people expecting "namespace smalltalk" to work,  maybe the best fix would be to hard-code the converstion to "st":
> (note: I ran the smalltalk generator this time to make sure the "category" line was there, but would in no way claim to have tested the smalltalk.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.