You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/06 22:39:16 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #14648: Update docs about baking DAGs in docker image

mik-laj commented on a change in pull request #14648:
URL: https://github.com/apache/airflow/pull/14648#discussion_r588940176



##########
File path: docs/helm-chart/manage-dags-files.rst
##########
@@ -18,20 +18,48 @@
 Manage DAGs files
 =================
 
-When you create new or modify existing DAG files, it is necessary to implement them into the environment. This section will describe some basic techniques you can use.
+When you create new or modify existing DAG files, it is necessary to deploy them into the environment. This section will describe some basic techniques you can use.
 
 Bake DAGs in Docker image
 -------------------------
 
-The recommended way to update your DAGs with this chart is to build a new docker image with the latest DAG code (``docker build -t my-company/airflow:8a0da78 . ``), push it to an accessible registry ```docker push my-company/airflow:8a0da78``), then update the Airflow pods with that image:
+The recommended way to update your DAGs with this chart is to build a new docker image with the latest DAG code:
+
+.. code-block:: bash
+
+    docker build --tag "my-company/airflow:8a0da78" . -f - <<EOF
+    FROM apache/airflow:2.0.1
+
+    USER root
+
+    COPY --chown=airflow:root ./dags/ \${AIRFLOW_HOME}/dags/
+
+    USER airflow
+
+    EOF
+
+Then publish it in the accessible registry:
+
+.. code-block:: bash
+
+    docker push my-company/airflow:8a0da78
+
+Finally, update the Airflow pods with that image:
 
 .. code-block:: bash
 
     helm upgrade airflow . \
       --set images.airflow.repository=my-company/airflow \
       --set images.airflow.tag=8a0da78
 
-For local development purpose you can also build the image locally and use it via deployment method described by Breeze.

Review comment:
       This is documentation intended for the end-user, so it should not describe the contributor tools when it is not necessary. Besides, I don't understand this sentence.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org