You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "puchengy (via GitHub)" <gi...@apache.org> on 2023/12/08 18:33:06 UTC
[PR] Add doc for rewriting manifest with spec id [iceberg]
puchengy opened a new pull request, #9253:
URL: https://github.com/apache/iceberg/pull/9253
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add doc for rewriting manifest with spec id [iceberg]
Posted by "puchengy (via GitHub)" <gi...@apache.org>.
puchengy commented on PR #9253:
URL: https://github.com/apache/iceberg/pull/9253#issuecomment-1847647392
@RussellSpitzer Do you know how to format the doc and how to test the doc locally? I can't find the doc, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add doc for rewriting manifest with spec id [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #9253:
URL: https://github.com/apache/iceberg/pull/9253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add doc for rewriting manifest with spec id [iceberg]
Posted by "puchengy (via GitHub)" <gi...@apache.org>.
puchengy commented on PR #9253:
URL: https://github.com/apache/iceberg/pull/9253#issuecomment-1850509409
@aokolnychyi Addressed your comment, PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add doc for rewriting manifest with spec id [iceberg]
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #9253:
URL: https://github.com/apache/iceberg/pull/9253#discussion_r1421696977
##########
docs/spark-procedures.md:
##########
@@ -446,6 +446,7 @@ This procedure invalidates all cached Spark plans that reference the affected ta
|---------------|-----------|------|-------------|
| `table` | ✔️ | string | Name of the table to update |
| `use_caching` | ️ | boolean | Use Spark caching during operation (defaults to true) |
+| `spec_id` | | int | Spec id of the manifests to rewrite (defaults to latest spec id) |
Review Comment:
I think `latest` should be `current`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add doc for rewriting manifest with spec id [iceberg]
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #9253:
URL: https://github.com/apache/iceberg/pull/9253#discussion_r1424879348
##########
docs/spark-procedures.md:
##########
@@ -442,10 +442,11 @@ This procedure invalidates all cached Spark plans that reference the affected ta
#### Usage
-| Argument Name | Required? | Type | Description |
-|---------------|-----------|------|-------------|
-| `table` | ✔️ | string | Name of the table to update |
-| `use_caching` | ️ | boolean | Use Spark caching during operation (defaults to true) |
+| Argument Name | Required? | Type | Description |
+|---------------|-----------|------|---------------------------------------------------------------|
+| `table` | ✔️ | string | Name of the table to update |
+| `use_caching` | ️ | boolean | Use Spark caching during operation (defaults to true) |
+| `spec_id` | | int | Spec id of the manifests to rewrite (defaults to current spec id) |
Review Comment:
nit: we can have formatting as above line
```suggestion
| `spec_id` | ️ | int | Spec id of the manifests to rewrite (defaults to current spec id) |
```
##########
docs/spark-procedures.md:
##########
@@ -442,10 +442,11 @@ This procedure invalidates all cached Spark plans that reference the affected ta
#### Usage
-| Argument Name | Required? | Type | Description |
-|---------------|-----------|------|-------------|
-| `table` | ✔️ | string | Name of the table to update |
-| `use_caching` | ️ | boolean | Use Spark caching during operation (defaults to true) |
+| Argument Name | Required? | Type | Description |
+|---------------|-----------|------|---------------------------------------------------------------|
+| `table` | ✔️ | string | Name of the table to update |
+| `use_caching` | ️ | boolean | Use Spark caching during operation (defaults to true) |
+| `spec_id` | | int | Spec id of the manifests to rewrite (defaults to current spec id) |
Review Comment:
nit: we can have formatting as above line
```suggestion
| `spec_id` | ️ | int | Spec id of the manifests to rewrite (defaults to current spec id) |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org