[GitHub] [incubator-superset] ktmud commented on a change in pull request #9333: build: use manifest hooks for dev server proxy

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #9333:  build: use manifest hooks for dev server proxy
URL: https://github.com/apache/incubator-superset/pull/9333#discussion_r395409966
 
 

 ##########
 File path: superset-frontend/webpack.config.js
 ##########
 @@ -20,17 +20,17 @@
 const fs = require('fs');
 const path = require('path');
 const webpack = require('webpack');
-const BundleAnalyzerPlugin = require('webpack-bundle-analyzer')
-  .BundleAnalyzerPlugin;
+const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
 const { CleanWebpackPlugin } = require('clean-webpack-plugin');
 const CopyPlugin = require('copy-webpack-plugin');
 const MiniCssExtractPlugin = require('mini-css-extract-plugin');
 const OptimizeCSSAssetsPlugin = require('optimize-css-assets-webpack-plugin');
 const SpeedMeasurePlugin = require('speed-measure-webpack-plugin');
 const TerserPlugin = require('terser-webpack-plugin');
-const WebpackAssetsManifest = require('webpack-assets-manifest');
+const ManifestPlugin = require('webpack-manifest-plugin');
 
 Review comment:
    Replaced [WebpackAssetsManafestPlugin](https://github.com/webdeveric/webpack-assets-manifest) with [WebpackManifestPlugin](https://github.com/danethurber/webpack-manifest-plugin) because the latter is recommended by Webpack's official docs and seem to have more users. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org