You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2013/11/21 17:13:25 UTC
Backport WebSocketResource to wicket-6.x
Hi,
With https://issues.apache.org/jira/browse/WICKET-5423 I've implemented
IResource based WebSocket endpoint.
The benefit is that there is no locking on page instance to send/receive
web socket messages.
But I had to make some API breaks in IWebSocketConnectionRegistry.
Since Native WebSockets are experimental I think it is OK to backport the
improvement to wicket-6.x too.
Any objections ?
Re: Backport WebSocketResource to wicket-6.x
Posted by Sven Meier <sv...@meiers.net>.
+1
Sven
On 11/21/2013 05:13 PM, Martin Grigorov wrote:
> Hi,
>
> With https://issues.apache.org/jira/browse/WICKET-5423 I've implemented
> IResource based WebSocket endpoint.
> The benefit is that there is no locking on page instance to send/receive
> web socket messages.
>
> But I had to make some API breaks in IWebSocketConnectionRegistry.
> Since Native WebSockets are experimental I think it is OK to backport the
> improvement to wicket-6.x too.
>
> Any objections ?
>
Re: Backport WebSocketResource to wicket-6.x
Posted by Martijn Dashorst <ma...@gmail.com>.
In experimental modules we are allowed to break API–the version is < 1.0 :-)
Go for it!
Martijn
On Thu, Nov 21, 2013 at 5:13 PM, Martin Grigorov <mg...@apache.org> wrote:
> Hi,
>
> With https://issues.apache.org/jira/browse/WICKET-5423 I've implemented
> IResource based WebSocket endpoint.
> The benefit is that there is no locking on page instance to send/receive
> web socket messages.
>
> But I had to make some API breaks in IWebSocketConnectionRegistry.
> Since Native WebSockets are experimental I think it is OK to backport the
> improvement to wicket-6.x too.
>
> Any objections ?
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: Backport WebSocketResource to wicket-6.x
Posted by Martin Grigorov <mg...@apache.org>.
Thanks!
I'll document the change for the next release notes.
On Thu, Nov 21, 2013 at 6:29 PM, Emond Papegaaij
<em...@gmail.com>wrote:
> Breaking api in experimental modules is no problem to me, they are
> versioned 0.x with a reason :)
>
> Emond
>
>
> On Thu, Nov 21, 2013 at 5:13 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
>
> > Hi,
> >
> > With https://issues.apache.org/jira/browse/WICKET-5423 I've implemented
> > IResource based WebSocket endpoint.
> > The benefit is that there is no locking on page instance to send/receive
> > web socket messages.
> >
> > But I had to make some API breaks in IWebSocketConnectionRegistry.
> > Since Native WebSockets are experimental I think it is OK to backport the
> > improvement to wicket-6.x too.
> >
> > Any objections ?
> >
>
Re: Backport WebSocketResource to wicket-6.x
Posted by Emond Papegaaij <em...@gmail.com>.
Breaking api in experimental modules is no problem to me, they are
versioned 0.x with a reason :)
Emond
On Thu, Nov 21, 2013 at 5:13 PM, Martin Grigorov <mg...@apache.org>wrote:
> Hi,
>
> With https://issues.apache.org/jira/browse/WICKET-5423 I've implemented
> IResource based WebSocket endpoint.
> The benefit is that there is no locking on page instance to send/receive
> web socket messages.
>
> But I had to make some API breaks in IWebSocketConnectionRegistry.
> Since Native WebSockets are experimental I think it is OK to backport the
> improvement to wicket-6.x too.
>
> Any objections ?
>