[GitHub] [arrow-rs] viirya commented on a diff in pull request #2087: type_id and value_offset are incorrect for sliced UnionArray

[GitBox <gi...@apache.org>]

viirya commented on code in PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087#discussion_r922702220


##########
arrow/src/array/array_union.rs:
##########
@@ -383,6 +383,7 @@ mod tests {
     use crate::array::*;
     use crate::buffer::Buffer;
     use crate::datatypes::{DataType, Field};
+    use crate::record_batch::RecordBatch;

Review Comment:
   Hm? I need use `RecordBatch`, otherwise:
   
   ```
   error[E0412]: cannot find type `RecordBatch` in this scope
      --> arrow/src/array/array_union.rs:994:49
       |
   994 |         fn test_slice_union(record_batch_slice: RecordBatch) {
       |                                                 ^^^^^^^^^^^ not found in this scope
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org