You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "qianzhu18 (via GitHub)" <gi...@apache.org> on 2026/09/01 21:12:58 UTC
[PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
qianzhu18 opened a new pull request, #4511:
URL: https://github.com/apache/maka/pull/4511
## Summary
The same failure class as #4383, applied to the `packages/runtime-host` test suite. Several helpers poll for an asynchronous condition with a fixed count of macrotask ticks (or immediates). A tick count is not a time budget: on a loaded CI runner the underlying work — turn settlement over real UDS connections, agent-graph wake-run persistence, peer mesh roster propagation over real serve/join networking, usage and artifact persistence — can span more ticks than the loop allows, so the helper gives up before the condition is genuinely false and the failure cannot be distinguished from a real regression.
This converts the fixed-tick loops to the shared `waitFor` primitive from `@maka/core/test-only/async-primitives` with an explicit 5s wall-clock deadline and a 10ms poll interval:
- `execution-model-composition.test.ts` — graph-wake loop, `startTurn`, `waitForTerminal`, `waitForUsage`, `waitForCanonicalAttempts`, `waitForCaptureArtifacts`, `waitForAutomaticMemoryRequestsToSettle`
- `plan-two-client-uds.test.ts` — `waitForTerminal`
- `runtime-policy-coordinator.test.ts` — inline turn-settlement loop (now via the file's existing `pollFor` import)
- `peer-mesh.test.ts` — roster propagation loop (previously a 200ms budget)
- `peer-native.test.ts` — `waitForRequestCount` (previously 10 immediates)
Each helper keeps its failure message; `waitForCanonicalAttempts` and `waitForAutomaticMemoryRequestsToSettle` keep their detailed diagnostics by building them from the final state when the wait times out. The in-memory `setImmediate` helpers (`waitForPending`, `waitForGoalRun`) are intentionally left alone — they poll in-memory facades where a tick budget is effectively unbounded. Production behavior is unchanged; this is test-infrastructure only.
Fixes #4510
## Verification
- `npm run --workspace @maka/runtime-host build` — clean (no TS errors)
- `node --test` on all five converted files: 69/69 pass on macOS arm64 (28 in `execution-model-composition`, 11 `plan-two-client-uds`, 4 `peer-native`, 19 `peer-mesh`, 17 `runtime-policy-coordinator` — same totals as the pre-change baseline)
- `biome check` on the five files — clean
Not run: the repository-wide CI matrix (Windows-only suites noted in #4390 do not affect these files; none of the converted files is Windows-gated except `execution-model-composition`, which skips on win32 at the describe level).
## AI use
- [x] Generative tooling made a substantive contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4511: test(runtime-host): give async wait helpers explicit time budgets
URL: https://github.com/apache/maka/pull/4511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
Posted by "qianzhu18 (via GitHub)" <gi...@apache.org>.
qianzhu18 commented on PR #4511:
URL: https://github.com/apache/maka/pull/4511#issuecomment-5561527403
Rebased onto current `main` (was 183 commits behind — apologies, that was the triage blocker). CI should run on this push now.
Notes on the rebase, since two helpers had moved upstream:
- The graph-wake loop and `waitForCanonicalRequests` now poll upstream's newer semantics (invocation outcomes / `modelCallSummary`) under the same `waitFor` budget instead of tick counts; the capture-artifacts helper that upstream removed was not reintroduced.
- On the queued observation about a loosened budget: yes — the largest change is the peer-mesh roster-propagation wait (20×10ms ticks → a 5s wall-clock deadline). That loosening is the point rather than a side effect: 200ms was the flake-prone guess, and the deadline only ever fires when mesh propagation genuinely never completes, at the cost of a slower *failing* test. It matches the 5s precedent from #4387. That said, if you'd rather bound genuine-failure latency tighter (e.g. 2s for peer-mesh), happy to set per-helper budgets accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
Posted by "hqhq1025 (via GitHub)" <gi...@apache.org>.
hqhq1025 commented on code in PR #4511:
URL: https://github.com/apache/maka/pull/4511#discussion_r3945183189
##########
package-lock.json:
##########
@@ -446,9 +437,6 @@
"x64"
],
"dev": true,
- "libc": [
- "musl"
- ],
"license": "MIT",
Review Comment:
[P3] Preserve the lockfile's libc platform filters
This hunk and 35 similar entries remove the glibc/musl restrictions even though dependency versions are unchanged. It changes installation behavior outside the wait-helper scope: with Node 24.18.1/npm 11.19.0 on the same glibc 2.39 host, a clean install of this lockfile installs six musl native packages that a clean install retaining the base lockfile skips (Astro compiler, Biome, Satteri, Sharp/libvips and Oxc). Those extra packages occupy about 96 MiB locally. Please retain the existing libc metadata rather than bringing this platform-filter churn into a test timing change. This is an unnecessary install-footprint regression, not a claim that the incompatible binaries are executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4511:
URL: https://github.com/apache/maka/pull/4511#issuecomment-6183972472
<!-- maka-lifecycle:stale-close -->
This pull request has been closed because it received no new commits during the 7-day grace period. This is not a judgement on the merit of the change; it only keeps the review queue aligned with work that is actively in flight.
The branch and review history are preserved. Push a new commit and reopen the pull request whenever the work is ready to continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
Posted by "qianzhu18 (via GitHub)" <gi...@apache.org>.
qianzhu18 commented on PR #4511:
URL: https://github.com/apache/maka/pull/4511#issuecomment-5553749368
Friendly ping — this has been open ~5 days while the queue moves quickly, so it may have slipped past triage.
Two pointers that may help: it's the runtime-host counterpart of #4383 (the same fixed-tick wait-budget class that #4387 fixed for `packages/runtime`), and it closes #4510 with the full inventory listed there. I noticed #4510 was assigned after this PR was opened — no duplicate work is in flight (as noted on the issue).
Happy to split it per-file or adjust scope if that makes review easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] test(runtime-host): give async wait helpers explicit time budgets [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4511:
URL: https://github.com/apache/maka/pull/4511#issuecomment-6030561274
<!-- maka-lifecycle:stale-warning -->
This pull request has had no new commits for 30 days and has been marked stale. It will be closed in 7 days unless a new commit is pushed.
Comments do not reset this timer: only a new commit does. If the pull request is intentionally long-lived, a maintainer can apply the `pinned` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org