[GitHub] [tvm] Lunderberg commented on a change in pull request #9335: [MicroTVM][PyTest] Explicitly skip MicroTVM unittests.

[GitBox <gi...@apache.org>]

Lunderberg commented on a change in pull request #9335:
URL: https://github.com/apache/tvm/pull/9335#discussion_r733762985



##########
File path: tests/python/unittest/test_micro_project_api.py
##########
@@ -26,45 +26,48 @@
 
 import tvm
 
-pytest.importorskip("tvm.micro")
-from tvm.micro import project_api
 
+@tvm.testing.fixture
+def BaseTestHandler():
+    from tvm.micro import project_api
 
-class BaseTestHandler(project_api.server.ProjectAPIHandler):
+    class BaseTestHandler(project_api.server.ProjectAPIHandler):

Review comment:
       Thank you.  Most of the time I would try to move the possibly-missing imports into the test itself, but here it wasn't possible without moving the entire class definition as well.  Good point on the name shadowing, and I've updated the inner class definition to be "BaseTestHandler_Impl" instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org