[GitHub] gianm closed pull request #6324: allow 3 retries for failing tests

[GitBox <gi...@apache.org>]

gianm closed pull request #6324: allow 3 retries for failing tests
URL: https://github.com/apache/incubator-druid/pull/6324
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/test/java/org/apache/druid/data/input/impl/prefetch/PrefetchableTextFilesFirehoseFactoryTest.java b/api/src/test/java/org/apache/druid/data/input/impl/prefetch/PrefetchableTextFilesFirehoseFactoryTest.java
index 0e63f790c86..09bde1e2f78 100644
--- a/api/src/test/java/org/apache/druid/data/input/impl/prefetch/PrefetchableTextFilesFirehoseFactoryTest.java
+++ b/api/src/test/java/org/apache/druid/data/input/impl/prefetch/PrefetchableTextFilesFirehoseFactoryTest.java
@@ -125,6 +125,7 @@ public static void teardown() throws IOException
     for (File dir : FIREHOSE_TMP_DIRS) {
       FileUtils.forceDelete(dir);
     }
+    FIREHOSE_TMP_DIRS.clear(); // cleanup after ourselves (resolve issue with retries)
   }
 
   private static void assertResult(List<Row> rows)
diff --git a/pom.xml b/pom.xml
index 52e750db210..f95fb58843c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -92,6 +92,9 @@
         <repoOrgId>org-apache-id</repoOrgId>
         <repoOrgName>org-apache-name</repoOrgName>
         <repoOrgUrl>https://repository.apache.org/content/repositories/public/</repoOrgUrl>
+
+        <!-- Allow the handful of flaky tests with transient failures to pass. -->
+        <surefire.rerunFailingTestsCount>3</surefire.rerunFailingTestsCount>
     </properties>
 
     <modules>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org