You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/01 22:01:09 UTC
[kudu-CR] KUDU-2127: use provided scope for several dependencies
Hello Dan Burkert, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7944
to review the following change.
Change subject: KUDU-2127: use provided scope for several dependencies
......................................................................
KUDU-2127: use provided scope for several dependencies
Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
4 files changed, 22 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/7944/1
--
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
[kudu-CR] java: clarify the use of several compile scopes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7944
to look at the new patch set (#2).
Change subject: java: clarify the use of several compile scopes
......................................................................
java: clarify the use of several compile scopes
After some testing, we've learned that parquet-hadoop and sparkavro should
be in the compile scope because it's pretty rare to see them provided by
platform providers. I added some comments to help clarify this.
Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
4 files changed, 29 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/7944/2
--
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2127: use provided scope for several dependencies
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2127: use provided scope for several dependencies
......................................................................
Patch Set 1: Code-Review-2
Doing some cluster testing with Dan and it looks like we may need to keep spark-avro at compile scope, because it doesn't appear to be commonly provided by platform vendors.
--
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java: clarify the use of several compile scopes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: java: clarify the use of several compile scopes
......................................................................
java: clarify the use of several compile scopes
After some testing, we've learned that parquet-hadoop and sparkavro should
be in the compile scope because it's pretty rare to see them provided by
platform providers. I added some comments to help clarify this.
Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Reviewed-on: http://gerrit.cloudera.org:8080/7944
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client-tools/build.gradle
M java/kudu-client-tools/pom.xml
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
4 files changed, 29 insertions(+), 16 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: clarify the use of several compile scopes
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: java: clarify the use of several compile scopes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java: clarify the use of several compile scopes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: java: clarify the use of several compile scopes
......................................................................
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/7944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No