You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/25 17:24:01 UTC
[GitHub] [activemq] charlie-cyf opened a new pull request #640: AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest
charlie-cyf opened a new pull request #640:
URL: https://github.com/apache/activemq/pull/640
### Description
- This test is flaky because default 30s wait time is not enough for test run in CI env. [failed example](https://github.com/charlie-cyf/activemq/runs/2181716367?check_suite_focus=true#step:9:2214)
- changed wait time to maximum 10 min to fix this issue
### Testing
Tested on my local Github Actions CI run: https://github.com/charlie-cyf/activemq/runs/2190121520?check_suite_focus=true#step:7:870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre commented on pull request #640: AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #640:
URL: https://github.com/apache/activemq/pull/640#issuecomment-807141143
@charlie-cyf can you please rebase/squash your two commits ? Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] ehossack-aws commented on a change in pull request #640: AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest
Posted by GitBox <gi...@apache.org>.
ehossack-aws commented on a change in pull request #640:
URL: https://github.com/apache/activemq/pull/640#discussion_r601698059
##########
File path: activemq-unit-tests/src/test/java/org/apache/activemq/security/AbstractCachedLDAPAuthorizationMapLegacyTest.java
##########
@@ -322,7 +322,7 @@ public boolean isSatisified() throws Exception {
return map.context == null;
}
}
- });
+ }, 30*60*1000);
Review comment:
10 minutes seems like an unreasonable amount of time to wait for a single test. The CI build is super long already. Do you think it could be shorter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre commented on pull request #640: AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #640:
URL: https://github.com/apache/activemq/pull/640#issuecomment-807934506
For the record, you don't have to create a new PR. You can simply update this one with `git rebase -i origin/master` and squash the second commit to the first one, and then you just force push `git push --force charlie-cyf:AMQ8189`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] charlie-cyf closed pull request #640: AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest
Posted by GitBox <gi...@apache.org>.
charlie-cyf closed pull request #640:
URL: https://github.com/apache/activemq/pull/640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] Charlie-chenchrl commented on pull request #640: AMQ-8189 add wait time to CachedLDAPAuthorizationModuleTest
Posted by GitBox <gi...@apache.org>.
Charlie-chenchrl commented on pull request #640:
URL: https://github.com/apache/activemq/pull/640#issuecomment-807399319
Sure, new PR: https://github.com/apache/activemq/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org