You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/30 01:21:01 UTC
[GitHub] [incubator-superset] michellethomas commented on issue #7350:
Refactor out controlUtils.js module + unit tests
michellethomas commented on issue #7350: Refactor out controlUtils.js module + unit tests
URL: https://github.com/apache/incubator-superset/pull/7350#issuecomment-487796110
this lgtm thanks for doing this! I did a little testing with production data and didn't see any issues. You might want to sync up with @kristw before merging because this conflicts with https://github.com/apache/incubator-superset/pull/6827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org