You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/07 04:04:21 UTC
[GitHub] [apisix-dashboard] idbeta opened a new pull request #971: test: e2e test chash upstream with key (wrong key, vars)
idbeta opened a new pull request #971:
URL: https://github.com/apache/apisix-dashboard/pull/971
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] E2E test
- [ ] New feature provided
- [ ] Improve performance
- Related issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #971: test: e2e test chash upstream with key (wrong key, vars)
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #971:
URL: https://github.com/apache/apisix-dashboard/pull/971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #971: test: e2e test chash upstream with key (wrong key, vars)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #971:
URL: https://github.com/apache/apisix-dashboard/pull/971#issuecomment-739651226
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=h1) Report
> Merging [#971](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=desc) (ef7b7ae) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/971/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 43.41% 43.49% +0.07%
==========================================
Files 18 18
Lines 1299 1299
==========================================
+ Hits 564 565 +1
+ Misses 643 642 -1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/971/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=footer). Last update [8976cca...ef7b7ae](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #971: test: e2e test chash upstream with key (wrong key, vars)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #971:
URL: https://github.com/apache/apisix-dashboard/pull/971#issuecomment-739651226
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=h1) Report
> Merging [#971](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=desc) (c93600c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/971/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 43.41% 43.49% +0.07%
==========================================
Files 18 18
Lines 1299 1299
==========================================
+ Hits 564 565 +1
+ Misses 643 642 -1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/971/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=footer). Last update [8976cca...c93600c](https://codecov.io/gh/apache/apisix-dashboard/pull/971?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org