You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/31 06:00:18 UTC
[kudu-CR] [thirdparty] root can run postgres
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15613
Change subject: [thirdparty] root can run postgres
......................................................................
[thirdparty] root can run postgres
Sometimes Kudu development environment is run as a containerized VM
instance, and in such cases maintaining extra non-root users does not
make much difference. Also, mini_postgres databases are not targeted
for production use anyway. With that, it makes sense to allow to
run initdb and postgres process itself under UID 0 in the context of
mini_postgres as a part external mini-cluster test harness.
Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
---
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/postgres-no-check-root.patch
A thirdparty/patches/postgres-root-can-run-initdb.patch
4 files changed, 49 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/15613/1
--
To view, visit http://gerrit.cloudera.org:8080/15613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
Gerrit-Change-Number: 15613
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] root can run postgres
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15613 )
Change subject: [thirdparty] root can run postgres
......................................................................
[thirdparty] root can run postgres
Sometimes Kudu development environment is run as a containerized VM
instance, and in such cases maintaining extra non-root users does not
make much difference. Also, mini_postgres databases are not targeted
for production use anyway. With that, it makes sense to allow to
run initdb and postgres process itself under UID 0 in the context of
mini_postgres as a part external mini-cluster test harness.
Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
Reviewed-on: http://gerrit.cloudera.org:8080/15613
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M thirdparty/build-definitions.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/postgres-no-check-root.patch
A thirdparty/patches/postgres-root-can-run-initdb.patch
4 files changed, 49 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
Gerrit-Change-Number: 15613
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] root can run postgres
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 )
Change subject: [thirdparty] root can run postgres
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
Gerrit-Change-Number: 15613
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:24:59 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] root can run postgres
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 )
Change subject: [thirdparty] root can run postgres
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
Gerrit-Change-Number: 15613
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:56:37 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] root can run postgres
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15613 )
Change subject: [thirdparty] root can run postgres
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6501648140bed3ba0df08a468cdf22a84f88cfc
Gerrit-Change-Number: 15613
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 31 Mar 2020 06:42:51 +0000
Gerrit-HasComments: No