You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/18 20:29:49 UTC

Review Request 24808: Modify execute cli to run docker image

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

Modify execute cli to run docker image


Diffs
-----

  src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 

Diff: https://reviews.apache.org/r/24808/diff/


Testing
-------

make
Tested it manually as well.


Thanks,

Timothy Chen

Re: Review Request 24808: Modify execute cli to run docker image.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 6:35 a.m.)


Review request for mesos and Niklas Nielsen.


Changes
-------

I don't think the reviewbot problem is related. Niq please help commit this when you can


Repository: mesos-git


Description
-------

Review: https://reviews.apache.org/r/24808


Diffs
-----

  src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 

Diff: https://reviews.apache.org/r/24808/diff/


Testing
-------

make
Tested it manually as well.


Thanks,

Timothy Chen

Re: Review Request 24808: Modify execute cli to run docker image.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/
-----------------------------------------------------------

(Updated Aug. 24, 2014, 5:05 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Summary (updated)
-----------------

Modify execute cli to run docker image.


Repository: mesos-git


Description
-------

Review: https://reviews.apache.org/r/24808


Diffs (updated)
-----

  src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 

Diff: https://reviews.apache.org/r/24808/diff/


Testing
-------

make
Tested it manually as well.


Thanks,

Timothy Chen

Re: Review Request 24808: Modify execute cli to run docker image

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/#review50954
-----------------------------------------------------------


Patch looks great!

Reviews applied: [24808]

All tests passed.

- Mesos ReviewBot


On Aug. 18, 2014, 7:07 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24808/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 7:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/24808
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 
> 
> Diff: https://reviews.apache.org/r/24808/diff/
> 
> 
> Testing
> -------
> 
> make
> Tested it manually as well.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24808: Modify execute cli to run docker image

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/
-----------------------------------------------------------

(Updated Aug. 18, 2014, 7:07 p.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

Review: https://reviews.apache.org/r/24808


Diffs
-----

  src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 

Diff: https://reviews.apache.org/r/24808/diff/


Testing
-------

make
Tested it manually as well.


Thanks,

Timothy Chen

Re: Review Request 24808: Modify execute cli to run docker image

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/
-----------------------------------------------------------

(Updated Aug. 18, 2014, 7:07 p.m.)


Review request for drill, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description (updated)
-------

Review: https://reviews.apache.org/r/24808


Diffs (updated)
-----

  src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 

Diff: https://reviews.apache.org/r/24808/diff/


Testing
-------

make
Tested it manually as well.


Thanks,

Timothy Chen

Re: Review Request 24808: Modify execute cli to run docker image

Posted by Timothy Chen <tn...@apache.org>.

> On Aug. 18, 2014, 7:03 p.m., Niklas Nielsen wrote:
> > src/cli/execute.cpp, line 108
> > <https://reviews.apache.org/r/24808/diff/1/?file=662669#file662669line108>
> >
> >     How about leaving an example? It is the "docker:///" format, right?

Actually without the docker:///, just the docker image name itself.
Let me add an example then!


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/#review50920
-----------------------------------------------------------


On Aug. 18, 2014, 6:29 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24808/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 6:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modify execute cli to run docker image
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 
> 
> Diff: https://reviews.apache.org/r/24808/diff/
> 
> 
> Testing
> -------
> 
> make
> Tested it manually as well.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24808: Modify execute cli to run docker image

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/#review50920
-----------------------------------------------------------

Ship it!


Looks great! Looking forward to use this :-)


src/cli/execute.cpp
<https://reviews.apache.org/r/24808/#comment88803>

    How about leaving an example? It is the "docker:///" format, right?


- Niklas Nielsen


On Aug. 18, 2014, 11:29 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24808/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 11:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modify execute cli to run docker image
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 7e20f4c54f15047eb73948ca7eeac425160a8a85 
> 
> Diff: https://reviews.apache.org/r/24808/diff/
> 
> 
> Testing
> -------
> 
> make
> Tested it manually as well.
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>