You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "grigoni (via GitHub)" <gi...@apache.org> on 2025/06/14 14:55:50 UTC
[PR] More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
grigoni opened a new pull request, #1461:
URL: https://github.com/apache/activemq/pull/1461
second round about StringBuffer usage
use StringBuilder instead of StringBuffer: this avoids unnecessary sync
use StringBuilder best practice when concatenating
avoid concatenation in logging
use `java.nio.charset.StandardCharsets` for getBytes
use isEmpty() instead of `...length() > 0 `
some typos fixing
see https://issues.apache.org/jira/browse/AMQ-9732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3021794108
@grigoni yes I started to review it. Generally speaking, I'm not a big fan of large PR for code cleanup (when generated by tool or not). It's long to review (it touches different part of the code) and side effects can happen (for instance, using a not expected locale, ...).
So, instead of a super large PR changing everything at once, I would split into smaller chuncks.
That said for this PR, at first glance, it looks good, but I still have to do a new pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "grigoni (via GitHub)" <gi...@apache.org>.
grigoni closed pull request #1461: AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer
URL: https://github.com/apache/activemq/pull/1461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3021870944
@grigoni it's ok. Don't worry. I will do a pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "grigoni (via GitHub)" <gi...@apache.org>.
grigoni commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3805406574
closing this PR, current code base does not need this changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "grigoni (via GitHub)" <gi...@apache.org>.
grigoni commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3021770013
hello @jbonofre , @cshannon
my intention with this PR was to complete StringBuffer cleanup started with AMQ-9720
do you have a chance to review it?
thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "grigoni (via GitHub)" <gi...@apache.org>.
grigoni commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3021842071
@jbonofre
fully agree about large PR, if you prefer I'll split/remove some parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "grigoni (via GitHub)" <gi...@apache.org>.
grigoni commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3047311154
@mattrpav splitting makes definetely sense
I've rolled back the commit in my branch and **with same code** created a new one
which has commits by module and/or by fix type where changes were more specific
see: https://github.com/apache/activemq/pull/1471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1461:
URL: https://github.com/apache/activemq/pull/1461#issuecomment-3023385881
Breaking up the commits by type of fix and maven module is helpful in the event something need to be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact