You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2013/02/25 15:23:08 UTC
Review Request: Feature SNMP Alerts support in CloudStack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
Review request for cloudstack and Rajesh Battala.
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs
-----
client/pom.xml d532a42
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
debian/cloud-server.install f792cc2
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
> On March 6, 2013, 5:19 a.m., Rajesh Battala wrote:
> > plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java, line 1
> > <https://reviews.apache.org/r/9587/diff/1/?file=261699#file261699line1>
> >
> > why this class named ending with "2"?
It is suffixed with 2 due to conflict with SnmpConstants class of snmp4j library. I am using SnmpConstants of snmp4j library also in the same class so it is suffixed with 2 to increase the readability.
- Anshul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17450
-----------------------------------------------------------
On Feb. 25, 2013, 2:23 p.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 2:23 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml d532a42
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> debian/cloud-server.install f792cc2
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17450
-----------------------------------------------------------
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java
<https://reviews.apache.org/r/9587/#comment37021>
why this class named ending with "2"?
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java
<https://reviews.apache.org/r/9587/#comment37022>
valueToken will be null or the value in it will be null?
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java
<https://reviews.apache.org/r/9587/#comment37023>
why getting the substring with fixed numbers? will it not fail if the message varies?
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
<https://reviews.apache.org/r/9587/#comment37024>
Remove blank lines and empty spaces
- Rajesh Battala
On Feb. 25, 2013, 2:23 p.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 2:23 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml d532a42
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> debian/cloud-server.install f792cc2
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
> On March 6, 2013, 5:57 a.m., Rajesh Battala wrote:
> > plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java, line 2
> > <https://reviews.apache.org/r/9587/diff/1/?file=261699#file261699line2>
> >
> > As SnmpConstants class is already available from Library, you can rename this to CS Specific Snmp Constants instead of using number
will rename it to CloudStack specific
- Anshul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17458
-----------------------------------------------------------
On March 6, 2013, 11:01 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 11:01 a.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml cda6ab8
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17458
-----------------------------------------------------------
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java
<https://reviews.apache.org/r/9587/#comment37031>
As SnmpConstants class is already available from Library, you can rename this to CS Specific Snmp Constants instead of using number
- Rajesh Battala
On Feb. 25, 2013, 2:23 p.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 2:23 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml d532a42
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> debian/cloud-server.install f792cc2
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17456
-----------------------------------------------------------
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java
<https://reviews.apache.org/r/9587/#comment37028>
Here value in it can be null, some times clusterId is null so there is some possibility of getting value null
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java
<https://reviews.apache.org/r/9587/#comment37032>
This is based on fixed message pattern, not on fixed message. This part is basically handling the case when delimeters are present in message. Here fixed numbers are based on fixed pattern
usage/src/com/cloud/usage/UsageAlertManagerImpl.java
<https://reviews.apache.org/r/9587/#comment37033>
will remove the blank line and update the patch
- Anshul Gangwar
On Feb. 25, 2013, 2:23 p.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 2:23 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml d532a42
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> debian/cloud-server.install f792cc2
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17515
-----------------------------------------------------------
Anshul there still whitespaces and lines
please delete them and upload the patch.
- Rajesh Battala
On March 6, 2013, 11:01 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 11:01 a.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml cda6ab8
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17677
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On March 8, 2013, 8:07 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 8:07 a.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml cda6ab8
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On March 15, 2013, 1:46 p.m., Sateesh Chodapuneedi wrote:
> > Ship It!
Haven't merged this yet.
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17973
-----------------------------------------------------------
On March 12, 2013, 7:15 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 7:15 a.m.)
>
>
> Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml cda6ab8
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17973
-----------------------------------------------------------
Ship it!
Ship It!
- Sateesh Chodapuneedi
On March 12, 2013, 7:15 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 7:15 a.m.)
>
>
> Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml cda6ab8
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/#review17964
-----------------------------------------------------------
Ship it!
- Rajesh Battala
On March 12, 2013, 7:15 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9587/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 7:15 a.m.)
>
>
> Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value=""/>
> <param name="SnmpManagerPorts" value=""/>
> <param name="SnmpManagerCommunities" value=""/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
>
> <appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
> <param name="Threshold" value="WARN"/>
> <param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
> <param name="SnmpManagerPorts" value="162,162"/>
> <param name="SnmpManagerCommunities" value="public,public"/>
> <layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
> <param name="PairDelimeter" value="//"/>
> <param name="KeyValueDelimeter" value="::"/>
> </layout>
> </appender>
>
> This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
>
>
> Diffs
> -----
>
> client/pom.xml cda6ab8
> client/tomcatconf/log4j-cloud.xml.in 0866693
> core/src/com/cloud/alert/AlertManager.java a24e18c
> plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
> plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
> plugins/pom.xml 88f617b
> server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
> usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
>
> Diff: https://reviews.apache.org/r/9587/diff/
>
>
> Testing
> -------
>
> 9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 12, 2013, 7:15 a.m.)
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi.
Changes
-------
added Murali and Sateesh to review the code
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 11, 2013, 1:49 p.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
minor readability changes in this diff
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 11, 2013, 7:46 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
updated the patch as per Alex suggestions and squashed the commits in one
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 8, 2013, 8:07 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
update the patch minor changes in log4j-cloud.xml file and squashed the commits in one
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 7, 2013, 9:40 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
removed extra spaces and squashed the commits in one commit
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 7, 2013, 9:31 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
update the patch as per comments and squashed the changes in one commit
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 7, 2013, 9:26 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
update the patch as per comments and squashed the commits into one
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 7, 2013, 9:17 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
updated the patch as per comments and squashed the changes in one commit
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar
Re: Review Request: Feature SNMP Alerts support in CloudStack
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9587/
-----------------------------------------------------------
(Updated March 6, 2013, 11:01 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
Made the changes as per review comments and squashed the commits into one commit
Description
-------
This patch implements the SNMP Alerts support in CloudStack. With this feature one can configure log4j-cloud.xml to get the SNMP alerts. This feature uses the snmp4j library with Apache License. This feature is implemented by extending log4j Appeneder. Multiple SNMP Managers can be specified. To configure multiple SNMP Managers one needs to modify following portion in log4j-cloud.xml
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value=""/>
<param name="SnmpManagerPorts" value=""/>
<param name="SnmpManagerCommunities" value=""/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
To specify multiple SnmpManagerIpAddresses one has to give as follows with each SNMP Manager separated by ,
<appender name="SNMP" class="org.apache.cloudstack.alert.snmp.SnmpTrapAppender">
<param name="Threshold" value="WARN"/>
<param name="SnmpManagerIpAddresses" value="10.1.1.1,10.1.1.2"/>
<param name="SnmpManagerPorts" value="162,162"/>
<param name="SnmpManagerCommunities" value="public,public"/>
<layout class="org.apache.cloudstack.alert.snmp.SnmpEnhancedPatternLayout">
<param name="PairDelimeter" value="//"/>
<param name="KeyValueDelimeter" value="::"/>
</layout>
</appender>
This patch also resolves the bug https://issues.apache.org/jira/browse/CLOUDSTACK-960
This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-680.
Diffs (updated)
-----
client/pom.xml cda6ab8
client/tomcatconf/log4j-cloud.xml.in 0866693
core/src/com/cloud/alert/AlertManager.java a24e18c
plugins/alert-handlers/snmp-alerts/pom.xml PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/CsSnmpConstants.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayout.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpHelper.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapAppender.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpTrapInfo.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpEnhancedPatternLayoutTest.java PRE-CREATION
plugins/alert-handlers/snmp-alerts/test/org/apache/cloudstack/alert/snmp/SnmpTrapAppenderTest.java PRE-CREATION
plugins/pom.xml 88f617b
server/src/com/cloud/alert/AlertManagerImpl.java f8a8fd8
usage/src/com/cloud/usage/UsageAlertManagerImpl.java a0765b2
Diff: https://reviews.apache.org/r/9587/diff/
Testing
-------
9 unit tests have been written to test the functionality. Manually tested alert generation for few alerts.
Thanks,
Anshul Gangwar