You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fluss.apache.org by yu...@apache.org on 2025/09/15 03:53:17 UTC
(fluss) branch main updated: [hotfix] Enhance the log of rebuildWriterState (#1618)
This is an automated email from the ASF dual-hosted git repository.
yunhong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fluss.git
The following commit(s) were added to refs/heads/main by this push:
new 47980221b [hotfix] Enhance the log of rebuildWriterState (#1618)
47980221b is described below
commit 47980221b74db3d56a12d4adf385043b1021dd18
Author: Liebing <44...@users.noreply.github.com>
AuthorDate: Mon Sep 15 11:53:14 2025 +0800
[hotfix] Enhance the log of rebuildWriterState (#1618)
---
.../main/java/org/apache/fluss/server/log/LogSegments.java | 4 ++++
.../src/main/java/org/apache/fluss/server/log/LogTablet.java | 11 ++++++++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/fluss-server/src/main/java/org/apache/fluss/server/log/LogSegments.java b/fluss-server/src/main/java/org/apache/fluss/server/log/LogSegments.java
index 1a0c9a187..e908752a2 100644
--- a/fluss-server/src/main/java/org/apache/fluss/server/log/LogSegments.java
+++ b/fluss-server/src/main/java/org/apache/fluss/server/log/LogSegments.java
@@ -263,4 +263,8 @@ public final class LogSegments {
public long sizeInBytes() {
return segments.values().stream().mapToLong(LogSegment::getSizeInBytes).sum();
}
+
+ public TableBucket getTableBucket() {
+ return tableBucket;
+ }
}
diff --git a/fluss-server/src/main/java/org/apache/fluss/server/log/LogTablet.java b/fluss-server/src/main/java/org/apache/fluss/server/log/LogTablet.java
index fc0e7f27f..c23606850 100644
--- a/fluss-server/src/main/java/org/apache/fluss/server/log/LogTablet.java
+++ b/fluss-server/src/main/java/org/apache/fluss/server/log/LogTablet.java
@@ -1138,7 +1138,10 @@ public final class LogTablet {
} else {
offsetsToSnapshot.add(Optional.of(lastOffset));
}
- LOG.info("Loading writer state till offset {}", lastOffset);
+ LOG.info(
+ "Loading writer state for bucket {} till offset {}",
+ segments.getTableBucket(),
+ lastOffset);
// We want to avoid unnecessary scanning of the log to build the writer state when the
// tablet server is being upgraded. The basic idea is to use the absence of writer
// snapshot files to detect the upgrade case, but we have to be careful not to assume too
@@ -1164,7 +1167,8 @@ public final class LogTablet {
}
} else {
LOG.info(
- "Reloading from writer snapshot and rebuilding writer state from offset {}",
+ "Reloading from writer snapshot and rebuilding writer state for bucket {} from offset {}",
+ segments.getTableBucket(),
lastOffset);
boolean isEmptyBeforeTruncation =
writerStateManager.isEmpty() && writerStateManager.mapEndOffset() >= lastOffset;
@@ -1218,9 +1222,10 @@ public final class LogTablet {
writerStateManager.updateMapEndOffset(lastOffset);
writerStateManager.takeSnapshot();
LOG.info(
- "Writer state recovery took {} ms for snapshot load and {} ms for segment recovery from offset {}",
+ "Writer state recovery took {} ms for snapshot load and {} ms for segment recovery for bucket {} from offset {}",
segmentRecoveryStart - writerStateLoadStart,
System.currentTimeMillis() - segmentRecoveryStart,
+ segments.getTableBucket(),
lastOffset);
}
}