You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2016/04/25 20:39:09 UTC
Review Request 46651: AMBARI-16102: Inconsistency between grid and
list view of roles page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46651/
-----------------------------------------------------------
Review request for Ambari and Zhe (Joe) Wang.
Bugs: AMBARI-16102
https://issues.apache.org/jira/browse/AMBARI-16102
Repository: ambari
Description
-------
In the grid view, a user can be assigned more than one role just by typing the user name in 2 different role fields. But in list view you see/can choose only one role.
Attached : Screenshots.
The RMP suggested that the UI must allow just one role per user. We should add a check while adding users to roles in the grid view to check that a user is assigned only one role
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js e95ebdb
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js 6560f51
Diff: https://reviews.apache.org/r/46651/diff/
Testing
-------
Manually tested on live cluster.
Thanks,
Richard Zang
Re: Review Request 46651: AMBARI-16102: Inconsistency between grid
and list view of roles page
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46651/#review130499
-----------------------------------------------------------
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 25, 2016, 6:39 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46651/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 6:39 p.m.)
>
>
> Review request for Ambari and Zhe (Joe) Wang.
>
>
> Bugs: AMBARI-16102
> https://issues.apache.org/jira/browse/AMBARI-16102
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the grid view, a user can be assigned more than one role just by typing the user name in 2 different role fields. But in list view you see/can choose only one role.
> Attached : Screenshots.
> The RMP suggested that the UI must allow just one role per user. We should add a check while adding users to roles in the grid view to check that a user is assigned only one role
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js e95ebdb
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js 6560f51
>
> Diff: https://reviews.apache.org/r/46651/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>