You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Jeanne Waldman <je...@oracle.com> on 2008/11/14 00:03:11 UTC
Re:[Trinidad] move NullChangeManager to public API
adding [Trinidad] to the subject for those of you filtering.
Jeanne
Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
> Hi there,
>
> I'd like to move the import
> org.apache.myfaces.trinidadinternal.change.NullChangeManager class
> from the internal package to the public package. I can leave the
> internal copy there and deprecate it, like I see we've done
> //FastMessageFormat/./
>
> It is a generally useful class and our framework that includes
> Trinidad jars uses it.
>
> Let me know your thoughts.
>
> Thanks,
> Jeanne
>
Re: [Trinidad] move NullChangeManager to public API
Posted by Mike Kienenberger <mk...@gmail.com>.
I'd say that there's no reason to deprecate a class clearly packaged
as "trinidadinternal".
On 11/14/08, Jeanne Waldman <je...@oracle.com> wrote:
> Actually, I decided to be on the safe side to deprecate it, even if it is
> just for one release.
> Jeanne
>
> Jeanne Waldman wrote, On 11/14/2008 9:03 AM PT:
>
>
> > You know this class best, Prakash, so I will remove it.
> > Jeanne
> >
> > Prakash Udupa wrote, On 11/13/2008 3:46 PM PT:
> >
> > > I support moving it to public package, but instead of deprecating the
> internal copy can we just remove it ?.
> > >
> > > * NullChangeManager is default ChangeManager when there is none
> > > explicitly registered.
> > > * The only use is in
> > >
> org.apache.myfaces.trinidadinternal.context.RequestContextImpl,
> > > very very very unlikely there are any external usages.
> > >
> > > Thanks,
> > > Prakash
> > >
> > > Simon Lessard wrote:
> > >
> > > > Sounds acceptable to me.
> > > >
> > > > On Thu, Nov 13, 2008 at 6:03 PM, Jeanne Waldman
> <jeanne.waldman@oracle.com
> <ma...@oracle.com>> wrote:
> > > >
> > > > adding [Trinidad] to the subject for those of you filtering.
> > > >
> > > > Jeanne
> > > >
> > > > Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
> > > >
> > > > Hi there,
> > > >
> > > > I'd like to move the import
> > > >
> org.apache.myfaces.trinidadinternal.change.NullChangeManager
> > > > class from the internal package to the public package. I can
> > > > leave the internal copy there and deprecate it, like I see
> > > > we've done //FastMessageFormat/./
> > > >
> > > > It is a generally useful class and our framework that
> > > > includes Trinidad jars uses it.
> > > >
> > > > Let me know your thoughts.
> > > >
> > > > Thanks,
> > > > Jeanne
> > > >
> > > >
> > > >
> > >
> >
> >
>
Re: [Trinidad] move NullChangeManager to public API
Posted by Jeanne Waldman <je...@oracle.com>.
Actually, I decided to be on the safe side to deprecate it, even if it
is just for one release.
Jeanne
Jeanne Waldman wrote, On 11/14/2008 9:03 AM PT:
> You know this class best, Prakash, so I will remove it.
> Jeanne
>
> Prakash Udupa wrote, On 11/13/2008 3:46 PM PT:
>> I support moving it to public package, but instead of deprecating the
>> internal copy can we just remove it ?.
>>
>> * NullChangeManager is default ChangeManager when there is none
>> explicitly registered.
>> * The only use is in
>> org.apache.myfaces.trinidadinternal.context.RequestContextImpl,
>> very very very unlikely there are any external usages.
>>
>> Thanks,
>> Prakash
>>
>> Simon Lessard wrote:
>>> Sounds acceptable to me.
>>>
>>> On Thu, Nov 13, 2008 at 6:03 PM, Jeanne Waldman
>>> <jeanne.waldman@oracle.com <ma...@oracle.com>> wrote:
>>>
>>> adding [Trinidad] to the subject for those of you filtering.
>>>
>>> Jeanne
>>>
>>> Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
>>>
>>> Hi there,
>>>
>>> I'd like to move the import
>>> org.apache.myfaces.trinidadinternal.change.NullChangeManager
>>> class from the internal package to the public package. I can
>>> leave the internal copy there and deprecate it, like I see
>>> we've done //FastMessageFormat/./
>>>
>>> It is a generally useful class and our framework that
>>> includes Trinidad jars uses it.
>>>
>>> Let me know your thoughts.
>>>
>>> Thanks,
>>> Jeanne
>>>
>>>
>
Re: [Trinidad] move NullChangeManager to public API
Posted by Jeanne Waldman <je...@oracle.com>.
You know this class best, Prakash, so I will remove it.
Jeanne
Prakash Udupa wrote, On 11/13/2008 3:46 PM PT:
> I support moving it to public package, but instead of deprecating the
> internal copy can we just remove it ?.
>
> * NullChangeManager is default ChangeManager when there is none
> explicitly registered.
> * The only use is in
> org.apache.myfaces.trinidadinternal.context.RequestContextImpl,
> very very very unlikely there are any external usages.
>
> Thanks,
> Prakash
>
> Simon Lessard wrote:
>> Sounds acceptable to me.
>>
>> On Thu, Nov 13, 2008 at 6:03 PM, Jeanne Waldman
>> <jeanne.waldman@oracle.com <ma...@oracle.com>> wrote:
>>
>> adding [Trinidad] to the subject for those of you filtering.
>>
>> Jeanne
>>
>> Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
>>
>> Hi there,
>>
>> I'd like to move the import
>> org.apache.myfaces.trinidadinternal.change.NullChangeManager
>> class from the internal package to the public package. I can
>> leave the internal copy there and deprecate it, like I see
>> we've done //FastMessageFormat/./
>>
>> It is a generally useful class and our framework that
>> includes Trinidad jars uses it.
>>
>> Let me know your thoughts.
>>
>> Thanks,
>> Jeanne
>>
>>
Re: [Trinidad] move NullChangeManager to public API
Posted by Prakash Udupa <pr...@oracle.com>.
I support moving it to public package, but instead of deprecating the
internal copy can we just remove it ?.
* NullChangeManager is default ChangeManager when there is none
explicitly registered.
* The only use is in
org.apache.myfaces.trinidadinternal.context.RequestContextImpl,
very very very unlikely there are any external usages.
Thanks,
Prakash
Simon Lessard wrote:
> Sounds acceptable to me.
>
> On Thu, Nov 13, 2008 at 6:03 PM, Jeanne Waldman
> <jeanne.waldman@oracle.com <ma...@oracle.com>> wrote:
>
> adding [Trinidad] to the subject for those of you filtering.
>
> Jeanne
>
> Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
>
> Hi there,
>
> I'd like to move the import
> org.apache.myfaces.trinidadinternal.change.NullChangeManager
> class from the internal package to the public package. I can
> leave the internal copy there and deprecate it, like I see
> we've done //FastMessageFormat/./
>
> It is a generally useful class and our framework that includes
> Trinidad jars uses it.
>
> Let me know your thoughts.
>
> Thanks,
> Jeanne
>
>
Re: [Trinidad] move NullChangeManager to public API
Posted by Matthias Wessendorf <ma...@apache.org>.
On Fri, Nov 14, 2008 at 12:05 AM, Simon Lessard
<si...@gmail.com> wrote:
> Sounds acceptable to me.
yap.
+1 on this item
>
> On Thu, Nov 13, 2008 at 6:03 PM, Jeanne Waldman <je...@oracle.com>
> wrote:
>>
>> adding [Trinidad] to the subject for those of you filtering.
>>
>> Jeanne
>>
>> Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
>>>
>>> Hi there,
>>>
>>> I'd like to move the import
>>> org.apache.myfaces.trinidadinternal.change.NullChangeManager class from the
>>> internal package to the public package. I can leave the internal copy there
>>> and deprecate it, like I see we've done //FastMessageFormat/./
>>>
>>> It is a generally useful class and our framework that includes Trinidad
>>> jars uses it.
>>>
>>> Let me know your thoughts.
>>>
>>> Thanks,
>>> Jeanne
>>>
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [Trinidad] move NullChangeManager to public API
Posted by Simon Lessard <si...@gmail.com>.
Sounds acceptable to me.
On Thu, Nov 13, 2008 at 6:03 PM, Jeanne Waldman
<je...@oracle.com>wrote:
> adding [Trinidad] to the subject for those of you filtering.
>
> Jeanne
>
> Jeanne Waldman wrote, On 11/13/2008 2:23 PM PT:
>
> Hi there,
>>
>> I'd like to move the import
>> org.apache.myfaces.trinidadinternal.change.NullChangeManager class from the
>> internal package to the public package. I can leave the internal copy there
>> and deprecate it, like I see we've done //FastMessageFormat/./
>>
>> It is a generally useful class and our framework that includes Trinidad
>> jars uses it.
>>
>> Let me know your thoughts.
>>
>> Thanks,
>> Jeanne
>>
>>