You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/09/21 21:34:50 UTC

[GitHub] alficles commented on a change in pull request #2858: Prohibit content invalidation requests for no-origin DS types

alficles commented on a change in pull request #2858: Prohibit content invalidation requests for no-origin DS types
URL: https://github.com/apache/trafficcontrol/pull/2858#discussion_r219633374
 
 

 ##########
 File path: traffic_ops/app/lib/API/Job.pm
 ##########
 @@ -168,6 +168,10 @@ sub create_current_user_job {
 	if ( !defined($ds) ) {
 		return $self->not_found();
 	}
+	my $org_server_fqdn = UI::DeliveryService::compute_org_server_fqdn($self, $ds_id);
+	if ( !defined($org_server_fqdn) ) {
 
 Review comment:
   Should check for empty string as well as `!defined`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services