You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 00:05:39 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

HyukjinKwon opened a new pull request #31640:
URL: https://github.com/apache/spark/pull/31640


   ### What changes were proposed in this pull request?
   
   The endpoints of Prometheus metrics are properly marked and documented as an experimental (SPARK-31674). The class `PrometheusServlet` itself is not the part of an API so this PR proposes to remove it.
   
   ### Why are the changes needed?
   
   To avoid marking a non-API as an API.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, the class is already `private[spark]`.
   
   ### How was this patch tested?
   
   Existing tests should cover.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785523482


   Thanks @dongjoon-hyun!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785493377


   **[Test build #135443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135443/testReport)** for PR 31640 at commit [`d862981`](https://github.com/apache/spark/commit/d8629814d8fedcfeed8e2b5b5c03f4dc90bca94e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31640:
URL: https://github.com/apache/spark/pull/31640


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785507445


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40023/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785507445


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40023/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785548916


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135443/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785502425


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40023/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785493377


   **[Test build #135443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135443/testReport)** for PR 31640 at commit [`d862981`](https://github.com/apache/spark/commit/d8629814d8fedcfeed8e2b5b5c03f4dc90bca94e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785544423


   **[Test build #135443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135443/testReport)** for PR 31640 at commit [`d862981`](https://github.com/apache/spark/commit/d8629814d8fedcfeed8e2b5b5c03f4dc90bca94e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785548916


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135443/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785524111


   Thanks. Merged to master/3.1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31640: [SPARK-34531][CORE] Remove Experimental API tag in PrometheusServlet

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31640:
URL: https://github.com/apache/spark/pull/31640#issuecomment-785500810


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40023/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org