You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/09/11 17:12:07 UTC
[Issue 125613] New: Insert Picture form file do not work
https://issues.apache.org/ooo/show_bug.cgi?id=125613
Issue ID: 125613
Issue Type: DEFECT
Summary: Insert Picture form file do not work
Product: Impress
Version: 4.1.1
Hardware: PC
OS: Windows, all
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: ui
Assignee: issues@openoffice.apache.org
Reporter: jmpoo-bugz@arcor.de
Don't work in AOO 4.1.0, 4.1.1 and 4.2.0 dev r1623875, german
works last in AOO 4.0.1
Open Impress
insert a new slide
chose "Insert Picture" Button in the middle of the slide
insert any picture
notice that the "Insertion and Listing Mask" is always visible
but the inserted picture is not shown in slide preview or slide show
It appears, if you type any outline text.
Small pictures fills the whole frame as tiles.
So it works like inserting a background picture at the textframe.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture form file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
oooforum <oo...@free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oooforum@free.fr
--- Comment #2 from oooforum <oo...@free.fr> ---
Duplicate of issue 125387
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #17 from jmpoo <jm...@arcor.de> ---
Tested with AOO 4.2.0 r1658822 de
Works fine.
So the issue should be closed as "fixed"?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #16 from Regina Henschel <rb...@t-online.de> ---
"Commited into trunk" means, that the fix is integrated in the source. The
daily builds on http://ci.apache.org/projects/openoffice/install/ should work
well. If you find, that a daily build still shows this error, please write a
note here.
So no, this is not a "good one to try", because it is already fixed. Please
write a mail to dev@openoffice.apache.org. We can help you finding an
interesting task.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
slacka <lu...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orw@apache.org
--- Comment #7 from slacka <lu...@hotmail.com> ---
This may not be display issue. Impress slides created in LO and AOO <=4.0 show
the pictures fine in AOO 4.1+. Slides created in AOO 4.1+ are corrupted showing
blank images in the slideshow when viewed in all version of AOO and LO.
Oliver, any thoughts?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jenskreuels@gmx.de
--- Comment #9 from Regina Henschel <rb...@t-online.de> ---
*** Issue 125883 has been marked as a duplicate of this issue. ***
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #12 from Regina Henschel <rb...@t-online.de> ---
Further investigations show, that pPickObj exists, when any empty outline text
is on the slide, whether it is selected or not. So in my previous comment "then
pPickObj would not exist" is not right.
Why?
The method InsertGraphic is called by FuInsertGraphic::DoExecute in
sd/source/ui/fuinsert.cxx
It gets the pPickObj from the call GetEmptyPresentationObject(PRESOBJ_GRAPHIC)
and in case that fails, from a single marked object if any.
View::GetEmptyPresentationObject resides in sd/source/ui/view/sdview5.cxx
GetEmptyPresentationObject first looks, whether a single object is marked and
IsEmptyPresObj() and whether it belongs to those PresObjKind listed in
implIsMultiPresObj. It does not test the kind given in the parameter (in our
case a PRESOBJ_GRAPHIC), but returns any marked object in that list, which
IsEmptyPresObj(). So it will return any marked empty outline text. For me this
looks erroneous, I expect that a marked object is only returned if it has the
in the parameter given kind.
In case no object is marked, GetEmptyPresentationObject iterates through all
objects of given kind (here PRESOBJ_GRAPHIC) and returns the first with
IsEmptyPresObj().
At last step GetEmptyPresentationObject iterates through all from
GetPresentationShapeList and returns the first one with meets IsEmptyPresObj()
&& implIsMultiPresObj(). Here too the kind given in the parameter is not
tested, but all kind listed in implIsMultiPresObj will meet. The first one
listed is the kind PRESOBJ_OUTLINE. This behavior looks erroneous too for me.
Do objects of kinds listed in implIsMultiPresObj() other than PRESOBJ_OUTLINE
can be an IsEmptyPresObj()? What it the purpose of method
GetEmptyPresentationObject?
The error has other manifestations too:
Take a slide with an empty outline text. Do not mark the outline text. Insert a
formula. The formula replaces the outline text.
Take a slide with an empty outline text and a formula. (To get the formula
insert it from clipboard.) Mark the formula. Insert picture from file. The
background of the formula should be filled, but the outline text is filled
instead.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P1 |P2
CC| |rb.henschel@t-online.de
--- Comment #8 from Regina Henschel <rb...@t-online.de> ---
Read issue 124784, issue 123922 and issue 125387 too. The problem is, that
version 4.1+ put the image into the background of a text frame, if some is
present. The frame need not be activated, being present is sufficient. Effected
are presentation objects "Outline text" and "Subtitle" and graphic object "Text
frame" as well.
The fact, that the picture is not shown, is a side effect. The presentation
object is not shown in presentation mode, because it has only the placeholder
info but no real content. If you add some words, the presentation object and
its background is shown in presentation mode too.
Workaround for version 4.1: Insert a slide with a blank layout. Insert the
picture into that slide and from there copy and paste it to the target place.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #6 from slacka <lu...@hotmail.com> ---
Adding Armin to the CC because he's been working on the Impress graphics
engine. Do you have any idea why the slideshow is broken in 4.1?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #11 from Regina Henschel <rb...@t-online.de> ---
The fix for issue 123922 has introduced a new behavior in
sd/Source/ui/view/sdview4.cxx in method View::InsertGraphic.
When you click on the "insert picture" button in the middle of an empty
presentation object type 'text', then the presentation object becomes selected
automatically. With the new behavior you get in line #27:
pPickObj is true
!bIsGraphic is true since bIsGraphic is false
pPickObj->IsClosedObj is true
Therefore the case is cought and the selected presentation object is filled
with the picture as background.
Clicking on the button should not select the empty presentation object, then
pPickObj would not exist.
This is not the only error. Filling an empty presentation object, when nothing
is selected, is a different error. But I don't know the reason yet.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
Keith N. McKenna <kn...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
CC| |knmc@apache.org
Resolution|--- |FIXED
--- Comment #18 from Keith N. McKenna <kn...@apache.org> ---
Changed to resolved fixed per reporter jmpoo in Comment 17
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"regina" committed SVN revision 1650314 into trunk:
#i125613# Insert Picture from file do not work
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
Logan <mi...@g.cofc.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |minnixlc@g.cofc.edu
--- Comment #15 from Logan <mi...@g.cofc.edu> ---
(In reply to SVN Robot from comment #14)
> "regina" committed SVN revision 1650314 into trunk:
> #i125613# Insert Picture from file do not work
My team and I are aiming to fix bugs and thought that this would be a good one
to try. Even with the revision, does the bug need to be fixed? We would like to
fix this issue.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture form file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #1 from jmpoo <jm...@arcor.de> ---
Created attachment 83949
--> https://issues.apache.org/ooo/attachment.cgi?id=83949&action=edit
Impress - inserted picture is not shown
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #13 from Regina Henschel <rb...@t-online.de> ---
Filling the background of the placeholder outline can be fixed by adding the
condition
&&!(pPickObj->IsEmptyPresObj() )
to the "if" in line #112 in View::InsertGraphic in sdview4.cxx
But following problem remains:
When a placeholder outline is present, then inserting not via overlay but
directly, or inserting a formula, this will replace the placeholder outline
object. This happens even in the case another object (e.g. graphic or picture)
is selected.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
bmarcelly <ma...@club-internet.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |marcelly@club-internet.fr
Ever confirmed|0 |1
--- Comment #4 from bmarcelly <ma...@club-internet.fr> ---
Issue 125387 describes only part of the observed anomalies.
I think all the side-effects have to be investigated together, the current
situation is user-unfriendly.
Description of the effects, seen on Windows 7, Apache OpenOffice 4.1.1
Create a new Impress file, with one slide.
For the slide, choose in the sidebar one of the Layouts, except "Blank Slide".
- Either select a rectangle where you see "Click to add text", then menu Insert
> file.
- Or if you have chosen a layout with a Content, click on the grey mask "insert
Picture"
- choose an image with small dimensions
Consequences:
- you have to wait 2-3 seconds before the image appears, wondering what's going
on...
- then the small image appears many times as tiles to cover the surface of the
rectangle
- but the image does not appear in the Slide Pane
- run slideshow : the image does not appear
- return to edit mode; add some text in the rectangle. Then the tiled images
appear in the Slide Pane, and in the slideshow.
In LibreOffice 4.2.4 the same manipulations have a normal behaviour :
- the image appears instantly after being chosen
- the image appears correctly, both in design mode and slideshow
- once the image is inserted in the Content, the ". Click to add text"
disappears, the rectangle has been replaced by the image.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
--- Comment #10 from Regina Henschel <rb...@t-online.de> ---
Perhaps introduced with fix for issue 123922 (cs 1565510)?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
jmpoo <jm...@arcor.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Insert Picture form file do |Insert Picture from file do
|not work |not work
--- Comment #3 from jmpoo <jm...@arcor.de> ---
Maybee it's the same root cause but not a duplicate.
The main topic of my issue is the non visability of the inserted picture in
slide preview and slide show in addition to the always activated input template
- not the "mosaic effect".
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
Ariel Constenla-Haile <ar...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression
Latest|--- |4.2.0-dev
Confirmation on| |
--- Comment #5 from Ariel Constenla-Haile <ar...@apache.org> ---
And if you switch to another layout, the picture is gone.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125613] Insert Picture from file do not work
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125613
slacka <lu...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
CC| |Armin.Le.Grand@me.com,
| |lukebenes@hotmail.com
Severity|normal |critical
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.