You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Hyunsik Choi <hy...@apache.org> on 2014/01/29 08:26:35 UTC

Review Request 17485: TAJO-569: Add max(TEXT) function

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17485/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-569
    https://issues.apache.org/jira/browse/TAJO-569


Repository: tajo


Description
-------

There is min function for text parameter, where there is no max function for text parameter. We need to add it.


Diffs
-----

  CHANGES.txt 333740dfb907e5e9eb48057867a46676f15ad2bf 
  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/builtin/MaxString.java PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestBuiltinFunctions.java a6883237633a54fe6a53d635115dfceccdf67644 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestBuiltinFunctions/testMaxString.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestBuiltinFunctions/testMinString.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestBuiltinFunctions/testMaxString.result PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestBuiltinFunctions/testMinString.result PRE-CREATION 

Diff: https://reviews.apache.org/r/17485/diff/


Testing
-------


Thanks,

Hyunsik Choi

Re: Review Request 17485: TAJO-569: Add max(TEXT) function

Posted by Jihoon Son <ji...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17485/#review33200
-----------------------------------------------------------

Ship it!


Ship It!

- Jihoon Son


On Jan. 29, 2014, 7:27 a.m., Hyunsik Choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17485/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 7:27 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-569
>     https://issues.apache.org/jira/browse/TAJO-569
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> There is min function for text parameter, where there is no max function for text parameter. We need to add it.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt 333740dfb907e5e9eb48057867a46676f15ad2bf 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/builtin/MaxString.java PRE-CREATION 
>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestBuiltinFunctions.java a6883237633a54fe6a53d635115dfceccdf67644 
>   tajo-core/tajo-core-backend/src/test/resources/queries/TestBuiltinFunctions/testMaxString.sql PRE-CREATION 
>   tajo-core/tajo-core-backend/src/test/resources/queries/TestBuiltinFunctions/testMinString.sql PRE-CREATION 
>   tajo-core/tajo-core-backend/src/test/resources/results/TestBuiltinFunctions/testMaxString.result PRE-CREATION 
>   tajo-core/tajo-core-backend/src/test/resources/results/TestBuiltinFunctions/testMinString.result PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17485/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Hyunsik Choi
> 
>

Re: Review Request 17485: TAJO-569: Add max(TEXT) function

Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17485/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 4:27 p.m.)


Review request for Tajo.


Bugs: TAJO-569
    https://issues.apache.org/jira/browse/TAJO-569


Repository: tajo


Description
-------

There is min function for text parameter, where there is no max function for text parameter. We need to add it.


Diffs
-----

  CHANGES.txt 333740dfb907e5e9eb48057867a46676f15ad2bf 
  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/builtin/MaxString.java PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestBuiltinFunctions.java a6883237633a54fe6a53d635115dfceccdf67644 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestBuiltinFunctions/testMaxString.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestBuiltinFunctions/testMinString.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestBuiltinFunctions/testMaxString.result PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestBuiltinFunctions/testMinString.result PRE-CREATION 

Diff: https://reviews.apache.org/r/17485/diff/


Testing (updated)
-------

mvn clean install


Thanks,

Hyunsik Choi