[GitHub] [yunikorn-web] lixmgl commented on a diff in pull request #111: YUNIKORN-1557: expose build info in webapp

["lixmgl (via GitHub)" <gi...@apache.org>]

lixmgl commented on code in PR #111:
URL: https://github.com/apache/yunikorn-web/pull/111#discussion_r1188771238


##########
src/app/models/cluster-info.model.ts:
##########
@@ -18,8 +18,15 @@
 
 export interface ClusterInfo {
     startTime: number;
-    rmBuildInformation: string[];
+    rmBuildInformation: BuildInfo[];
     partition: string;
     clusterName: string;
     clusterStatus?: string;
 }
+
+export interface BuildInfo {
+    buildDate: string;
+    buildVersion: string;
+    isPluginVersion: string,
+    rmId: string;
+}

Review Comment:
   @0yukali0 thanks for reviewing the pr, I added a new line.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org