[GitHub] mistercrunch closed pull request #5657: [bugfix] df is None breaks df.empty check

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5657: [bugfix] df is None breaks df.empty check
URL: https://github.com/apache/incubator-superset/pull/5657
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/viz.py b/superset/viz.py
index e50ee1b77a..edbfbb0ffd 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -198,7 +198,7 @@ def get_df(self, query_obj=None):
         # be considered as the default ISO date format
         # If the datetime format is unix, the parse will use the corresponding
         # parsing logic.
-        if not df.empty:
+        if df is not None and not df.empty:
             if DTTM_ALIAS in df.columns:
                 if timestamp_format in ('epoch_s', 'epoch_ms'):
                     # Column has already been formatted as a timestamp.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org