You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/15 06:09:02 UTC

[GitHub] [incubator-eventmesh] SteveYurongSu opened a new issue #438: Enable Github Actions for Checkstyle

SteveYurongSu opened a new issue #438:
URL: https://github.com/apache/incubator-eventmesh/issues/438


   ## Enhancement Request
   
   <!-- 
   First of all: Have you checked the docs https://github.com/apache/incubator-eventmesh/tree/develop/docs, 
   or GitHub issues whether someone else has already reported your issue? 
   -->
   
   ### Is your enhancement request related to a problem? Please describe
   
   <!-- 
   A clear and concise description of what the enhancement is.
   -->
   
   I noticed that there are folks working on issue #428 (#431), translating or removing Chinese chars in code.
   Manually checking for this kind of code style can be a pain.
   But, we can make the process of code style check automated with less pain by introducing Checkstyle into CI.
   
   ### Describe the solution you'd like
   
   <!-- 
   A clear and concise description of what you want to happen. Add any considered drawbacks.
   -->
   
   I'd like to define a Checkstyle workflow in CI.
   The Checkstyle workflow will always pass and will provide a report after each run. 
   The report includes the code style issues found in the workflow, and it can be a reference for reviewers.
   
   
   ### Describe alternatives you've considered
   
   <!-- 
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   * Github Actions: Checkstyle check + reviewdog report 
   * Github Actions: Spotless check
   
   ### Additional context
   
   <!-- 
   Add any other context or screenshots about the enhancement request here.
   -->
   
   reviewdog: https://github.com/reviewdog/reviewdog
   checkstyle-idea: https://plugins.jetbrains.com/plugin/1065-checkstyle-idea
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] SteveYurongSu commented on issue #438: Enable Github Actions for Checkstyle

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on issue #438:
URL: https://github.com/apache/incubator-eventmesh/issues/438#issuecomment-880709657


   Yes, we can also check our code style in IDE.
   
   ![image](https://user-images.githubusercontent.com/30497621/125798875-78b4649a-4a8e-4746-8172-337b42367fbd.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] SteveYurongSu commented on issue #438: Enable Github Actions for Checkstyle

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on issue #438:
URL: https://github.com/apache/incubator-eventmesh/issues/438#issuecomment-880712367


   Hi @qqeasonchen @xwm1992 , my PR is ready, please take a look 😊😊
   BTW, This PR may help #428 (#431).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] SteveYurongSu closed issue #438: Enable Github Actions for Checkstyle

Posted by GitBox <gi...@apache.org>.
SteveYurongSu closed issue #438:
URL: https://github.com/apache/incubator-eventmesh/issues/438


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org