[GitHub] [hbase] mnpoonia commented on a change in pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

[GitBox <gi...@apache.org>]

mnpoonia commented on a change in pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#discussion_r662147527



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
##########
@@ -275,11 +275,11 @@
 
   /**
    * Check if normalization enable flag of the table is true. If flag is false
-   * then no region normalizer won't attempt to normalize this table.
+   * then region normalizer won't attempt to normalize this table.
    *
-   * @return true if region normalization is enabled for this table
+   * @return value of NORMALIZATION_ENABLED key for this table if present else return null
    */
-  boolean isNormalizationEnabled();
+  Boolean isNormalizationEnabled();

Review comment:
       @virajjasani - Not sure how using enum will help in maintaining compatibility. Yes it will surely improve code redabolity but It will face the same problem. Am i missing something here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org