You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/20 11:36:15 UTC
[GitHub] [maven-release] theit opened a new pull request #32: Add support
for the "--pin-externals" operations in SCM branch and tag operations
theit opened a new pull request #32: Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32
This PR adds support for the "--pin-externals" option in SCM branch and tag operations. This feature was introducted in Subversion 1.9 and is available in maven-scm-plugin since version 1.11.1.
See also
- https://issues.apache.org/jira/browse/MRELEASE-549
- https://issues.apache.org/jira/browse/SCM-805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-571557231
Schedulung for the end of the week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on a change in pull request #32:
[MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370493975
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmTagPhase.java
##########
@@ -168,6 +171,10 @@ public ReleaseResult simulate( ReleaseDescriptor releaseDescriptor, ReleaseEnvir
logInfo( result, "Full run would be tagging remotely " + basedirAlignedReleaseDescriptor.getScmSourceUrl()
+ " with label: '" + releaseDescriptor.getScmReleaseLabel() + "'" );
}
+ if ( releaseDescriptor.isPinExternals() )
+ {
+ logInfo( result, "Full run would pin externals" );
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578449733
You did not rebase, you have produced a merge commit.
```
git checkout <branch>
git rebase master
# fix merge conflicts
git rebase --continue
git push --force
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on a change in pull request #32:
[MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370493887
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmBranchPhase.java
##########
@@ -143,6 +144,10 @@ public ReleaseResult simulate( ReleaseDescriptor releaseDescriptor, ReleaseEnvir
logInfo( result, " To SCM URL: " + releaseDescriptor.getScmBranchBase() );
}
logInfo( result, " with label: '" + releaseDescriptor.getScmReleaseLabel() + "'" );
+ if ( releaseDescriptor.isPinExternals() )
+ {
+ logInfo( result, " with pinned externals" );
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o edited a comment on issue #32:
[MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-571557231
Scheduling for the end of the week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on a change in pull request
#32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370071275
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmBranchPhase.java
##########
@@ -143,6 +144,10 @@ public ReleaseResult simulate( ReleaseDescriptor releaseDescriptor, ReleaseEnvir
logInfo( result, " To SCM URL: " + releaseDescriptor.getScmBranchBase() );
}
logInfo( result, " with label: '" + releaseDescriptor.getScmReleaseLabel() + "'" );
+ if ( releaseDescriptor.isPinExternals() )
+ {
+ logInfo( result, " with pinned externals" );
Review comment:
with => and.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on a change in pull request
#32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370070779
##########
File path: maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
##########
@@ -481,4 +481,12 @@
* @return String
*/
String getAutoResolveSnapshots();
+
+ /**
+ * Get whether the "--pin-externals" option in svn copy commands is enabled
Review comment:
use `@code` for the formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on a change in pull request
#32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370070674
##########
File path: maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
##########
@@ -481,4 +481,12 @@
* @return String
*/
String getAutoResolveSnapshots();
+
+ /**
+ * Get whether the "--pin-externals" option in svn copy commands is enabled
Review comment:
Get => Determines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578521240
Created a branch for, running ITs on Jenkins, Windows and FreeBSD...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-571621112
Great, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578495141
Still fishy:
```
$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
mosipov@mikaw10 MINGW64 /d/Entwicklung/Projekte/maven-release (master)
$ git pull
Already up to date.
mosipov@mikaw10 MINGW64 /d/Entwicklung/Projekte/maven-release (master)
$ git merge theit/MRELEASE-549
Auto-merging maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
CONFLICT (content): Merge conflict in maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Auto-merging maven-release-manager/src/main/mdo/release-descriptor.mdo
CONFLICT (content): Merge conflict in maven-release-manager/src/main/mdo/release-descriptor.mdo
Auto-merging maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java
Auto-merging maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java
Auto-merging maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java
CONFLICT (content): Merge conflict in maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java
Auto-merging maven-release-manager/src/main/java/org/apache/maven/shared/release/config/PropertiesReleaseDescriptorStore.java
Auto-merging maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
CONFLICT (content): Merge conflict in maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
Automatic merge failed; fix conflicts and then commit the result.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-567914104
I will look at this next week. Please ping me on Tue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578012895
@michael-o: I thought about a test, but honestly I don't know if that makes sense. This PR simply adds a boolean flag to the release descriptor and forwards it to the SCM implementation, i.e. maven-scm-plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578034713
Will take another look this afternoon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on a change in pull request
#32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370071421
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmTagPhase.java
##########
@@ -120,13 +120,16 @@ public ReleaseResult execute( ReleaseDescriptor releaseDescriptor, ReleaseEnviro
new ScmTagParameters( releaseDescriptor.getScmCommentPrefix() + "copy for tag " + tagName );
scmTagParameters.setRemoteTagging( releaseDescriptor.isRemoteTagging() );
scmTagParameters.setScmRevision( releaseDescriptor.getScmReleasedPomRevision() );
+ scmTagParameters.setPinExternals( releaseDescriptor.isPinExternals() );
if ( getLogger().isDebugEnabled() )
{
getLogger().debug(
"ScmTagPhase :: scmTagParameters remotingTag " + releaseDescriptor.isRemoteTagging() );
getLogger().debug(
"ScmTagPhase :: scmTagParameters scmRevision " + releaseDescriptor.getScmReleasedPomRevision() );
getLogger().debug( "ScmTagPhase :: fileSet " + fileSet );
+ getLogger().debug(
+ "ScmTagPhase :: scmTagParameters pinExternals " + releaseDescriptor.isPinExternals() );
Review comment:
Move this up to the other parameter logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on a change in pull request #32:
[MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370493856
##########
File path: maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
##########
@@ -481,4 +481,12 @@
* @return String
*/
String getAutoResolveSnapshots();
+
+ /**
+ * Get whether the "--pin-externals" option in svn copy commands is enabled
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] asfgit closed pull request #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on a change in pull request
#32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370072056
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmTagPhase.java
##########
@@ -168,6 +171,10 @@ public ReleaseResult simulate( ReleaseDescriptor releaseDescriptor, ReleaseEnvir
logInfo( result, "Full run would be tagging remotely " + basedirAlignedReleaseDescriptor.getScmSourceUrl()
+ " with label: '" + releaseDescriptor.getScmReleaseLabel() + "'" );
}
+ if ( releaseDescriptor.isPinExternals() )
+ {
+ logInfo( result, "Full run would pin externals" );
Review comment:
This should be consistent with the other log statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578504846
Yeah sorry, typical user error... 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578539537
@theit New branch passes all tests. Have a look, I will merge in 24 h.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578398215
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on a change in pull request #32:
[MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370493806
##########
File path: maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java
##########
@@ -481,4 +481,12 @@
* @return String
*/
String getAutoResolveSnapshots();
+
+ /**
+ * Get whether the "--pin-externals" option in svn copy commands is enabled
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-577522442
Ping...? 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] michael-o commented on issue #32: [MRELEASE-549]
Add support for the "--pin-externals" operations in SCM branch and tag
operations
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-578396960
Please rebase against master and I will run tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on a change in pull request #32:
[MRELEASE-549] Add support for the "--pin-externals" operations in SCM
branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370493950
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmTagPhase.java
##########
@@ -120,13 +120,16 @@ public ReleaseResult execute( ReleaseDescriptor releaseDescriptor, ReleaseEnviro
new ScmTagParameters( releaseDescriptor.getScmCommentPrefix() + "copy for tag " + tagName );
scmTagParameters.setRemoteTagging( releaseDescriptor.isRemoteTagging() );
scmTagParameters.setScmRevision( releaseDescriptor.getScmReleasedPomRevision() );
+ scmTagParameters.setPinExternals( releaseDescriptor.isPinExternals() );
if ( getLogger().isDebugEnabled() )
{
getLogger().debug(
"ScmTagPhase :: scmTagParameters remotingTag " + releaseDescriptor.isRemoteTagging() );
getLogger().debug(
"ScmTagPhase :: scmTagParameters scmRevision " + releaseDescriptor.getScmReleasedPomRevision() );
getLogger().debug( "ScmTagPhase :: fileSet " + fileSet );
+ getLogger().debug(
+ "ScmTagPhase :: scmTagParameters pinExternals " + releaseDescriptor.isPinExternals() );
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add
support for the "--pin-externals" operations in SCM branch and tag operations
Posted by GitBox <gi...@apache.org>.
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#issuecomment-571530928
@michael-o: Did you already have a chance to look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services