You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Fabulich (JIRA)" <ji...@codehaus.org> on 2009/02/18 03:08:19 UTC
[jira] Created: (MENFORCER-64) Fail the build if children in a
reactor don't declare a parent
Fail the build if children in a reactor don't declare a parent
--------------------------------------------------------------
Key: MENFORCER-64
URL: http://jira.codehaus.org/browse/MENFORCER-64
Project: Maven 2.x Enforcer Plugin
Issue Type: New Feature
Reporter: Dan Fabulich
Children in a reactor build are allowed to declare any parent POM they like, or no POM at all. It should be possible to fail the build if a child declares the wrong parent pom (which should normally be the root of the reactor, but may be configured to be something else).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MENFORCER-64) Fail the build if children in a
reactor don't declare a parent
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166757#action_166757 ]
Dan Fabulich commented on MENFORCER-64:
---------------------------------------
I'd pay that price of "consistency." In the project I was working on last week, one of the reactor projects failed to declare its parent properly, and so it dodged around the enforcer entirely.
The fact that it *consistently* avoided all rules (both when run independently and when run in a reactor) was no comfort!
It might help to phrase it this way: normally enforcer rules apply directly to the individual leaf projects in a reactor, but this rule would probably apply to the reactor root itself. The *parent* would assert that its reactor modules were children. Hence it makes sense that the children themselves can run independently: they're not asserting anything.
> Fail the build if children in a reactor don't declare a parent
> --------------------------------------------------------------
>
> Key: MENFORCER-64
> URL: http://jira.codehaus.org/browse/MENFORCER-64
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Reporter: Dan Fabulich
>
> Children in a reactor build are allowed to declare any parent POM they like, or no POM at all. It should be possible to fail the build if a child declares the wrong parent pom (which should normally be the root of the reactor, but may be configured to be something else).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MENFORCER-64) Fail the build if children in a
reactor don't declare a parent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166662#action_166662 ]
Brian Fox commented on MENFORCER-64:
------------------------------------
This seems hard to do consistently. If a module doesn't declare a parent and it is run independently, it won't fail, but it would if it was in a reactor?
> Fail the build if children in a reactor don't declare a parent
> --------------------------------------------------------------
>
> Key: MENFORCER-64
> URL: http://jira.codehaus.org/browse/MENFORCER-64
> Project: Maven 2.x Enforcer Plugin
> Issue Type: New Feature
> Reporter: Dan Fabulich
>
> Children in a reactor build are allowed to declare any parent POM they like, or no POM at all. It should be possible to fail the build if a child declares the wrong parent pom (which should normally be the root of the reactor, but may be configured to be something else).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira