You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by yotammadem <gi...@git.apache.org> on 2016/03/09 08:36:54 UTC
[GitHub] cxf pull request: Avoid lock on read
GitHub user yotammadem opened a pull request:
https://github.com/apache/cxf/pull/119
Avoid lock on read
This is seems to be a bottle neck in our performance tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yotammadem/cxf 3.1.x-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit dac7288b53e0ae989cde6889ed845e7071a04dc3
Author: yotamm <yo...@il.ibm.com>
Date: 2016-03-09T07:25:36Z
Avoid lock on read
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Avoid lock on read (issue: https://issues.apache...
Posted by yotammadem <gi...@git.apache.org>.
Github user yotammadem commented on the pull request:
https://github.com/apache/cxf/pull/119#issuecomment-194287251
So what do you suggest to do?
Maybe we should use some other data structure (one of the concurrent ones)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Avoid lock on read (issue: https://issues.apache...
Posted by yotammadem <gi...@git.apache.org>.
Github user yotammadem commented on the pull request:
https://github.com/apache/cxf/pull/119#issuecomment-194292794
What do you mean by invalid?
I understand that it can return null because it didn't find the thread in the map
but do you think it is really possible for it to return something else?
(in the case of null my code is treating it well)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Avoid lock on read (issue: https://issues.apache...
Posted by yotammadem <gi...@git.apache.org>.
Github user yotammadem commented on the pull request:
https://github.com/apache/cxf/pull/119#issuecomment-200600098
I am closing this, will open other one when fix is ready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Avoid lock on read (issue: https://issues.apache...
Posted by yotammadem <gi...@git.apache.org>.
Github user yotammadem closed the pull request at:
https://github.com/apache/cxf/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Avoid lock on read (issue: https://issues.apache...
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the pull request:
https://github.com/apache/cxf/pull/119#issuecomment-194280245
You HAVE to have the lock on the get as well as the put. During the put, the entire map is allowed to be restructured internally (buckets recalculated, etc... if the map grows) which would make anything going on in the get invalid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---