[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19752: fix: can't tigger delete event on SqlaTable

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #19752:
URL: https://github.com/apache/superset/pull/19752#discussion_r852520935


##########
tests/integration_tests/datasets/commands_tests.py:
##########
@@ -250,6 +250,7 @@ def test_import_v0_dataset_cli_export(self):
         }
         command = v0.ImportDatasetsCommand(contents)
         command.run()
+        db.session.commit()

Review Comment:
   It's a flaky test here. The `after_insert` in the `SqlaTable`  doesn't run `commit` finally, so the Postgresql probably does not preserve shadow tables.



##########
tests/integration_tests/datasets/commands_tests.py:
##########
@@ -290,6 +291,7 @@ def test_import_v0_dataset_ui_export(self):
         }
         command = v0.ImportDatasetsCommand(contents)
         command.run()
+        db.session.commit()

Review Comment:
   same before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org