You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/23 12:02:04 UTC
[GitHub] [incubator-superset] aspedrosa opened a new pull request #10410: Row limit in filter box
aspedrosa opened a new pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410
### SUMMARY
Currently there is a hard coded row limit on FilterBox.
I added the row limit control to the filter box visualization control panel so the user can customize this limit.
However the new default limit is 50000, imposed by the control itself.
There was another pull request (#8101) that fixed this but placed the row limit within each field being filtered, but this leads to having several row limit selects.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

### TEST PLAN
Suppose that the rendering of controls cover this :thinking:
### ADDITIONAL INFORMATION
- [x] Has associated issue: #7971
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10410: fix: row limit in filter box
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410#issuecomment-718375901
I think personally I prefer the approach in https://github.com/apache/incubator-superset/pull/8101, looks like the PR got dropped, but it should be easy to revive/update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] aspedrosa commented on pull request #10410: fix: row limit in filter box
Posted by GitBox <gi...@apache.org>.
aspedrosa commented on pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410#issuecomment-679187682
Closing to rerun the CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10410: fix: row limit in filter box
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410#issuecomment-718388727
I'd also vote for reviving #8101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] aspedrosa closed pull request #10410: fix: row limit in filter box
Posted by GitBox <gi...@apache.org>.
aspedrosa closed pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] tooptoop4 commented on pull request #10410: fix: row limit in filter box
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410#issuecomment-718299813
@villebro can this be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #10410: fix: row limit in filter box
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410#issuecomment-718375901
I think personally I prefer the approach in https://github.com/apache/incubator-superset/pull/8101, looks like the PR got dropped, but it should be easy to revive/update it.
Also for the record you can change the 50k default value by using a `controlOverride`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org