You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2026/01/01 13:02:11 UTC
(maven-pmd-plugin) branch grammar created (now b199a61)
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a change to branch grammar
in repository https://gitbox.apache.org/repos/asf/maven-pmd-plugin.git
at b199a61 Grammar nits
This branch includes the following new commits:
new b199a61 Grammar nits
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(maven-pmd-plugin) 01/01: Grammar nits
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch grammar
in repository https://gitbox.apache.org/repos/asf/maven-pmd-plugin.git
commit b199a61277a0d05b2f3ff0815d29e0127490dd5d
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Thu Jan 1 08:02:01 2026 -0500
Grammar nits
---
src/it/multi-module/mod-1/src/main/config/pmd/latin-1.xml | 2 +-
src/main/java/org/apache/maven/plugins/pmd/PmdReport.java | 12 ++++++------
.../java/org/apache/maven/plugins/pmd/PmdReportRenderer.java | 8 ++++----
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/it/multi-module/mod-1/src/main/config/pmd/latin-1.xml b/src/it/multi-module/mod-1/src/main/config/pmd/latin-1.xml
index 58cd8d2..45b15db 100644
--- a/src/it/multi-module/mod-1/src/main/config/pmd/latin-1.xml
+++ b/src/it/multi-module/mod-1/src/main/config/pmd/latin-1.xml
@@ -24,5 +24,5 @@ under the License.
This ruleset is encoded with ISO-8859-1 to check proper encoding handling.
</description>
<rule ref="category/java/codestyle.xml/UnnecessaryReturn" message="LATIN-1-CHARS: ���������"/>
- <!-- note: ���� = 0xBC 0xBD 0xBE 0xA4 don't exist any more in Latin 15, replaced by OE oe Y" and euro -->
+ <!-- note: ���� = 0xBC 0xBD 0xBE 0xA4 don't exist anymore in Latin 15, replaced by OE oe Y" and euro -->
</ruleset>
diff --git a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
index ba8ebc4..39b3f3c 100644
--- a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
+++ b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
@@ -152,8 +152,8 @@ public class PmdReport extends AbstractPmdReport {
/**
* Enables the analysis cache, which speeds up PMD. This
- * requires a cache file, that contains the results of the last
- * PMD run. Thus the cache is only effective, if this file is
+ * requires a cache file that contains the results of the last
+ * PMD run. Thus, the cache is only effective if this file is
* not cleaned between runs.
*
* @since 3.8
@@ -164,9 +164,9 @@ public class PmdReport extends AbstractPmdReport {
/**
* The location of the analysis cache, if it is enabled.
* This file contains the results of the last PMD run and must not be cleaned
- * between consecutive PMD runs. Otherwise the cache is not in use.
- * If the file doesn't exist, PMD executes as if there is no cache enabled and
- * all files are analyzed. Otherwise only changed files will be analyzed again.
+ * between consecutive PMD runs. Otherwise, the cache is not in use.
+ * If the file doesn't exist, PMD executes as if no cache is enabled and
+ * all files are analyzed. Otherwise, only changed files will be analyzed again.
*
* @since 3.8
*/
@@ -386,7 +386,7 @@ public class PmdReport extends AbstractPmdReport {
// in the current project's directory
locator.addSearchPath(FileResourceLoader.ID, project.getBasedir().getAbsolutePath());
// in the base directory - that's the directory of the initial pom requested to build,
- // e.g. the root of a multi module build
+ // e.g. the root of a multi-module build
locator.addSearchPath(FileResourceLoader.ID, session.getRequest().getBaseDirectory());
locator.setOutputDirectory(rulesetsTargetDirectory);
diff --git a/src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java b/src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java
index ebbf1fa..f499370 100644
--- a/src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java
+++ b/src/main/java/org/apache/maven/plugins/pmd/PmdReportRenderer.java
@@ -201,7 +201,7 @@ public class PmdReportRenderer extends AbstractMavenReportRenderer {
sink.tableRow_();
}
- // PMD might run the analysis multi-threaded, so the violations might be reported
+ // PMD might run the analysis multithreaded, so the violations might be reported
// out of order. We sort them here by filename and line number before writing them to
// the report.
private void renderViolations() {
@@ -310,7 +310,7 @@ public class PmdReportRenderer extends AbstractMavenReportRenderer {
}
}
- // PMD might run the analysis multi-threaded, so the suppressed violations might be reported
+ // PMD might run the analysis multithreaded, so the suppressed violations might be reported
// out of order. We sort them here by filename before writing them to
// the report.
private void renderSuppressedViolations() {
@@ -363,8 +363,8 @@ public class PmdReportRenderer extends AbstractMavenReportRenderer {
return;
}
- // sort the problem by filename first, since PMD is executed multi-threaded
- // and might reports the results unsorted
+ // sort the problem by filename first, since PMD is executed multithreaded
+ // and might report the results unsorted.
List<ProcessingError> processingErrorsCopy = new ArrayList<>(processingErrors);
Collections.sort(processingErrorsCopy, new Comparator<ProcessingError>() {
@Override