You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2015/04/07 08:58:07 UTC

[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...

Github user jerryshao commented on the pull request:

    https://github.com/apache/spark/pull/5288#issuecomment-90405437
  
    Hi @JoshRosen , sorry for late response, looks like I missed this notification. The reason why here changes to `InheritableThreadLocal` is that: we have such a scenario, we enabled FairScheduler in Spark with two groups, one group is running streaming program, and another group is running query, they separated in two threads and shared with same SparkContext, since streaming job is running in a threadpool when submitted to Spark DAGScheduler, so if we do not use `InheritableThreadLocal`, we cannot get the right value in child thread, so I changed to this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org