You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 20:21:35 UTC

[GitHub] [arrow-rs] alamb opened a new pull request, #3253: Update object_store version to 0.5.2 and add CHANGELOG

alamb opened a new pull request, #3253:
URL: https://github.com/apache/arrow-rs/pull/3253

   # Which issue does this PR close?
   
   re https://github.com/apache/arrow-rs/issues/3229
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on a diff in pull request #3253: Update object_store version to 0.5.2 and add CHANGELOG

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3253:
URL: https://github.com/apache/arrow-rs/pull/3253#discussion_r1037553149


##########
object_store/dev/release/update_change_log.sh:
##########
@@ -49,8 +49,8 @@ docker run -it --rm -e CHANGELOG_GITHUB_TOKEN="$CHANGELOG_GITHUB_TOKEN" -v "$(pw
     --cache-file=.githubchangeloggenerator.cache \
     --cache-log=.githubchangeloggenerator.cache.log \
     --http-cache \
-    --max-issues=300 \
-    --exclude-tags-regex "^\d+\.\d+\.\d+$" \
+    --max-issues=600 \

Review Comment:
   need to fetch 600 issues to get some of the older ones that have been resolved!



##########
object_store/dev/release/update_change_log.sh:
##########
@@ -49,8 +49,8 @@ docker run -it --rm -e CHANGELOG_GITHUB_TOKEN="$CHANGELOG_GITHUB_TOKEN" -v "$(pw
     --cache-file=.githubchangeloggenerator.cache \
     --cache-log=.githubchangeloggenerator.cache.log \
     --http-cache \
-    --max-issues=300 \
-    --exclude-tags-regex "^\d+\.\d+\.\d+$" \
+    --max-issues=600 \
+    --exclude-tags-regex "(^\d+\.\d+\.\d+$)|(rc)" \

Review Comment:
   Also I needed to exclude the 'rc' tags so it didn't make changelog entries for `26.0.0_rc1` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] ursabot commented on pull request #3253: Update object_store version to 0.5.2 and add CHANGELOG

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3253:
URL: https://github.com/apache/arrow-rs/pull/3253#issuecomment-1335808645

   Benchmark runs are scheduled for baseline = ecbb8c23765ff6530ca32b5b3139713d6aaebfed and contender = 74b174ca7a6c11d2b410334f45aa399987b35fc0. 74b174ca7a6c11d2b410334f45aa399987b35fc0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ddb02b5ddc8c4a95ad5534cf64756f7f...b408cc6247204e64ae85c4e459355c67/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/261414ed2cd94a95aa1c1553d482492b...2322d8d6725f4cc7874f5eb53304cbdf/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/dac2a494ce8e409b8d06a2b1c8e1e996...2fb17a67b17d4effaad1f8def3a5e22d/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8104d8c788c048a28e92121f364b6659...148699c4f0434ebeb4d10a4fad3867ba/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on pull request #3253: Update object_store version to 0.5.2 and add CHANGELOG

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3253:
URL: https://github.com/apache/arrow-rs/pull/3253#issuecomment-1335805873

   > It would be awesome for https://github.com/apache/arrow-rs/pull/3256 to make this release, but otherwise this looks good
   
   It is in!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb merged pull request #3253: Update object_store version to 0.5.2 and add CHANGELOG

Posted by GitBox <gi...@apache.org>.
alamb merged PR #3253:
URL: https://github.com/apache/arrow-rs/pull/3253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org