[GitHub] [netbeans] tmysik commented on a change in pull request #1418: [NETBEANS-1047] Don't add whitespace to a wrong place when textual operators are used

[GitBox <gi...@apache.org>]

tmysik commented on a change in pull request #1418: [NETBEANS-1047] Don't add whitespace to a wrong place when textual operators are used
URL: https://github.com/apache/netbeans/pull/1418#discussion_r312739183
 
 

 ##########
 File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/FormatVisitor.java
 ##########
 @@ -2558,4 +2560,9 @@ protected static boolean isWhitespace(final CharSequence text) {
     private static boolean isAnonymousClass(ASTNode astNode) {
         return astNode instanceof ClassInstanceCreation && ((ClassInstanceCreation) astNode).isAnonymous();
     }
+
+    private static boolean isPHPOperator(PHPTokenId id) {
 
 Review comment:
   Could be maybe moved to some `util` class as it seems to me to be quite useful in general. Not sure about that so just a hint.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists